Seneral / Node_Editor_Framework

A flexible and modular Node Editor Framework for creating node based displays and editors in Unity
https://nodeeditor.seneral.dev
MIT License
2.01k stars 415 forks source link

Update Dialog System with Modular Support #122

Closed atrblizzard closed 7 years ago

atrblizzard commented 7 years ago
Seneral commented 7 years ago

Hey, good to see you're keeping it up to date:) Can merge it anytime you want. Also will message Baste so he can give you access so you don't need to wait for me lol

atrblizzard commented 7 years ago

Awesome, appreciate it! I'll try my best to keep updating the dialog system where it's suitable. Right now it'll require develop branch, but can definitely be merged so we can have an updated base to work with. :)

Baste-RainGames commented 7 years ago

@Seneral, can't you give them access? It's under Settings/Collaborators.

If not, I'll fix it, no problem.

Seneral commented 7 years ago

@Baste-RainGames I have no access to the settings for some reason, but now that you mention it, I should be, right? Maybe you changed a settings somewhere? Didn't bother me until now, but would be nice to maintain this framework without depending on one person;)

Baste-RainGames commented 7 years ago

Looking into it, it seems like I have to transfer the ownership of the repo to you to make that work.

That'd probably be the ideal solution. Is that fine with you?

Seneral commented 7 years ago

Would be best indeed, but I'm unsure in regards to links. Seems like the repo link would redirect automatically but the gh-pages (documentation) link will change without a redirect... Anyway, would be best in the long run for both of us:) Thank you so much for creating this repo in the first place though! ;)

Seneral commented 7 years ago

@atrblizzard Alright, repo transferred and you should be a collaborator now:)

Seneral commented 7 years ago

Any news? Else I'll merge in a few days:)

atrblizzard commented 7 years ago

Sorry about that, I swear I thought it was already commited! Should have the new commits ready soon enough :)

Seneral commented 7 years ago

No problem! :) Glad you've not abandoned it;)