search

Seneral / Node_Editor_Framework

A flexible and modular Node Editor Framework for creating node based displays and editors in Unity
https://nodeeditor.seneral.dev
MIT License
2.01k stars 415 forks source link

Example Branch 'Dialogue System' is not up to date with latest develop #133

Closed game-libgdx-unity closed 6 years ago

game-libgdx-unity commented 7 years ago

Steps I have done:

  1. Create new project with Unity 5.5
  2. Clone develop branch, copy the cloned folder to the project (No error)
  3. Clone Dialogue System branch, copy the cloned folder to the project (15 errors)

image

Please help me, thank you so much!

Seneral commented 7 years ago

Hey, the example branch hasn't beem updated with the latest changes yet (which were alot). If you're ok with the missing features you can go back a few weeks to dff7d93 and it should work:) Problem is, I'm not the manager of that example, need to ask @ChicK00o and @atrblizzard for help with upgrading if they do have time. Mightt try it though when I have time... Seneral

ChicK00o commented 7 years ago

Will have a look at this on the coming weekend

game-libgdx-unity commented 7 years ago

Thank you so much for your answer, I tried the old commit, the errors have gone, but when I run the scene of example, it's just a black screen. Is this intended to happen?

I will tried older commit and let you know soon

image

game-libgdx-unity commented 7 years ago

I'm sorry for messing up, the example would run properly if we press 'L' key, but it;s still from the old commit

Quyrean commented 6 years ago

Hello,

I am new to the Node editor (really cool btw) and have updated the dialog editor example code to work with the latest dev branch and the new connection system. What would be the procedure to post this for review if anyone wants it? I am not very experienced with git and the examples being a different branch is confusing because there are not dev/main branches for the examples.

thanks,

Jen...

Seneral commented 6 years ago

Hey, that sounds great @Quyrean :) thanks! It's indeed a bit complicated, especially if you've never done it before. Git repositories work through so called 'Pull Requests' which essentially is a request from anyone for his commit to be 'pulled' into the main branch he is targetting. I assume you already done so, if not, fork this project (top right) so you have a own working copy of it, commit your changes to the example to your forked example branch (through command line or some GUI interface like SourceTree). You should then have a commit on your side and your example branch should be up to date with your changes. Then you can create a pull request from your branch to the main example branch of this repository through this online interface:) If you need more info, look it up, it is complicated but there're planty of resources available online:) Seneral

Quyrean commented 6 years ago

Ok, posted. Thanks for the info.

Seneral commented 6 years ago

Sorry for not responding, things gotten in the way:) Will try to take a look at it, but already looks solid. Thanks! :) Seneral

Seneral commented 6 years ago

Thanks to @Quyrean , just merged his port:)