search

Seneral / Node_Editor_Framework

A flexible and modular Node Editor Framework for creating node based displays and editors in Unity
https://nodeeditor.seneral.dev
MIT License
2.01k stars 414 forks source link

New icons #57

Closed groud closed 8 years ago

groud commented 8 years ago

I replaced the node editor window Icon by a colorless one. I believe it stands out a little bit less and blends better in the editor.

How do you think ? :)

pmhpereira commented 8 years ago

Can you provide a screenshot with the new icons? I made the current ones and need you to convince me yours are better. :P

groud commented 8 years ago

Here it is : screenshot

Seneral commented 8 years ago

Does match the style of the default icons better imo. Doesn't matter too much though but I'd merge it if everyone is ok;)

pmhpereira commented 8 years ago

When I added the current ones (with color), I made them with the objective of looking different from the default Unity ones, to reinforce the fact that it is a plugin and that it support various types of nodes.

Your version is simpler but blends better with the UI. Looks cool!

For reference, the current ones:

Let's see what @Seneral thinks. :-)

pmhpereira commented 8 years ago

I'm not against it. I'll forever keep mine in my heart. :heart: Merge away! :D

@groud could you provide a screenshot of the icon for the Unity Pro skin? Just to make sure it fits well. :-)

groud commented 8 years ago

@pmhpereira I do not have unity pro, but here is a montage ^^ donthaveunitypro

pmhpereira commented 8 years ago

@groud I don't either! ;-)

Looks good to me!

Seneral commented 8 years ago

I'm currently kinda rushing to get a commit to the action node out before sleeping, we can see tomorrow, ok?