search

Seneral / Node_Editor_Framework

A flexible and modular Node Editor Framework for creating node based displays and editors in Unity
https://nodeeditor.seneral.dev
MIT License
2.01k stars 414 forks source link

Duplicate Node (very rarely) causes two nodes to be created #83

Closed snarlynarwhal closed 8 years ago

snarlynarwhal commented 8 years ago

I never had this happen to me, but once I passed the tool off to the content creators, they ran into this issue where 50% of the time, Duplicate Node would create an extra duplicate (two copies). Any idea what might be causing this or how I might fix it?

Seneral commented 8 years ago

Sorry, missed it... which branch are you using? I've tested the develop branch (the way to go as the master branch hasn't been synced for a long time) and it is working fine 100% of the time:/

Seneral commented 8 years ago

Also tested the current master branch right now, fully working, even though the duplicated node is always at the top left (fixed in develop)

Seneral commented 8 years ago

Can you send me the code of your nodes? Does it also happens on the standard nodes? Because I only could imagine an error in the initialization function to cause this, even though that wouldn't explain the irregularities (50%)

snarlynarwhal commented 8 years ago

It's still working 100% for me also. The bug occurs on my colleague's machine. o.0 So it must be some sort of corrupt data or asset, right? The extra duplicate node appears on-top of the first duplicate node so it appears as if it worked until you drag the node and see the extra one.

BTW, I'm using development also. It can't be code related it if we have the same scripts and it works for me and not him, right? Let me find out if it happens with the standard nodes though - I'll get back to you Mon or Tues once I can test again on his machine. :)

Seneral commented 8 years ago

I can't think of any data corruption that would affect duplication, but weird things may happen when using scene saving as it's relatively new. Can you send me the asset if it is asset related or the scene if the asset was saved to the scene?

Seneral commented 8 years ago

I have an upcoming update on my side that might fix this, but I'm not sure. It depends on how your artist uses the framework... It'll be ready soon;)

snarlynarwhal commented 8 years ago

The team has been in crunch mode to release a milestone today, so haven't been able to bug the content developers for the past week or so, but the issue has yet to occur on my machine. :) But hopefully it fixes it! Once it's ready, you'll merge with the main branch and make a new release?

Seneral commented 8 years ago

I hope I can merge as long as develop is stable enough. Last time I planned to do it it turned out not to be stable which resulted in another big delay as I couldn't find time to fix the new bugs. But hope is there;)

Seneral commented 8 years ago

@pi3butcher Finally committed 336a537, the update I was talking about. Can you check if this fixes it for your colleague?

Seneral commented 8 years ago

If not, please reopen, but for now I'll close as I've never been able to reproduce it:)