search

Seneral / Node_Editor_Framework

A flexible and modular Node Editor Framework for creating node based displays and editors in Unity
https://nodeeditor.seneral.dev
MIT License
2.01k stars 414 forks source link

Unable to build after cloning #85

Closed rc1 closed 8 years ago

rc1 commented 8 years ago

Hello.

Using a fresh clone of the develop branch into a new unity project, I cannot build this. I am on OSX with Unity 5.3.5f1.

There error is on HotkeyAttribute and EventHandlerAttribute.

screen shot 2016-07-21 at 15 14 09

The quite fix to get it to compile is to make priority read/write by removing the private keyword for priority in the implementation of both HotkeyAttribute and EventHandlerAttribute. However I don't know what the consequences are. I am just trying out Node_Editor.

Cheers, Ross

Seneral commented 8 years ago

Yep, that should be no problem. I didn't know that this is handled differently on some platforms... best to go that way then:) Maybe it's the Unity version (I'm still at 5.3.4) but for me it works fine on windows. What is your build target at? Seneral

rc1 commented 8 years ago

Build target is "PC, Mac & Linux" at the moment. I'm downloading the latest Unity just now. Thanks

Seneral commented 8 years ago

Well, I don't have the latest unity to test, that is;) I think your version, 5.3.5, is the latest, so don't worry. Ok so it is likely related to OSX, seems that library of mono does handle optional named parameters differently. So a simple fix like yours will do:) Thanks for bringing this up!

DennyScott commented 8 years ago

Hey Seneral, I'm having the same issue on Windows, but Im on version 5.3.6.. Build Target is PC.

Seneral commented 8 years ago

Ok, @ChicK00o did create a fix for this in #84 which we're preparing for merge right now:)