search

Senither / hypixel-discord-chat-bridge

A two-way chat bridge between Hypixel guild chat and Discord.
MIT License
29 stars 119 forks source link

Added the Weight Command #34

Open KlaasNiphaas opened 3 years ago

KlaasNiphaas commented 3 years ago

Just added a weight command.

KlaasNiphaas commented 3 years ago

A few suggestions:

  • In order to make adding new commands easier to add, it may be worth putting all api related methods inside their own class and adding it as a property on either the App or Minecraft objects, so to get the data you could just add the line const playerData = this.minecraft.apiHandler.getPlayerData(<ign>) or something similar.

I don't fully understand this code (with all the this. and classes) but i'll try.

KlaasNiphaas commented 3 years ago

A few suggestions:

  • In order to make adding new commands easier to add, it may be worth putting all api related methods inside their own class and adding it as a property on either the App or Minecraft objects, so to get the data you could just add the line const playerData = this.minecraft.apiHandler.getPlayerData(<ign>) or something similar.

I don't fully understand this code (with all the this. and classes) but i'll try.

I tried for quite some time but i can't make it work :/