search

Sennevds / RFXcomIdGenerator

Generate RFXcom ID for Home Assistant
MIT License
22 stars 7 forks source link

Bug identified when unitID>9 #7

Closed scastoldiprivate closed 12 months ago

scastoldiprivate commented 1 year ago

For example, the following command : python generateId.py -t Lighting1 -s ARC -p C,11 gives 07100100430110000, which is invalid in Home Assistant. Problem appears when unitID is >9 UnitID should be one hex digit in the result Correct result is : 07100100430B0000

Same for command : python generateId.py -t Lighting1 -s ARC -p D,12 gives : 07100100440120000 (invalid) should give 07100100440C0000

Both of these examples were verified and working with Home Assistant v2023.7.3 with a RFXCOM RFX433XL and 2 working remote plug switches.

zombiefredrik commented 12 months ago

@scastoldiprivate fixed in pull request - don't know if this project is alive, but I just needed it for some old waveman stuff, and since I was in the code ...

Sennevds commented 12 months ago

I'm not updating the project myself because I don't need it anymore but if there are PR's I will gladly approve them