search

Sennevds / media_player.template

Template media_player for Home Assistant
MIT License
126 stars 23 forks source link

Naming consistency - media_album_artist_template #25

Open Seperis opened 3 years ago

Seperis commented 3 years ago

This is super minor and basically a matter of naming consistency

To keep consistency, you might change "media_album_artist_template" to "album_artisttemplate" for consistency in your template. Both 'artist' and "album" don't have 'media' in front, which I assume is because they're music; "media_album_artisttemplate" also is music-exclusive so as a visual reference to what content-type this template is associated with. I noticed--and appreciate--that tv-related uses the prefix 'media' (season, episode, series name). It's not a big deal, and I verified changing the name doesn't make any real difference other than when I'm reading the code. I can make the change and do the pull if you want, but like I said, it's really just a code consistency thing.

This template is working gangbusters for my Combined Media Player, so thank you. This has been bar none the most useful and fun single custom_component I've played with.

Sennevds commented 3 years ago

Hi really sorry for the late reply. Could you make a pr? I don't know when I have time to set everything up again after several formats of my pc and quiet busy personal life at the moment