SenorPez / project-cars-replay-enhancer

Project CARS Replay Enhancer: Combines telemetry data with replay video to improve Project CARS replays.
MIT License
12 stars 1 forks source link

Showing 10 instead of 11 drivers in replay #109

Closed Michel-NL closed 7 years ago

Michel-NL commented 7 years ago

Yesterday created a new replay with 11 drivers but in the video it only shows 10 drivers. The starting grid pictures show 11 drivers but as soon as the race starts it are only 10 drivers. During the race 1 driver disconnected. https://youtu.be/5a0IJ

Config file: (https://github.com/SenorPez/project-cars-replay-enhancer/files/635859/psnracing.txt)

SenorPez commented 7 years ago

Did the 11th driver start the race and drop out? Could you ZIP up the telemetry and send it to me? Multiplayer races are good, because I can catch edge cases like this... he should be showing up!

Michel-NL commented 7 years ago

Yes he started the race and had a disconnect.

Telemetry zip: https://1drv.ms/u/s!AkpjgvuA0hKBl6t54saHQTBNN3mnNw

Michel-NL commented 7 years ago

In the new version of the configuration editor I see two new lines. "leader_window_size" : 10, Is this causing to show only ten drivers? I changed it to eleven, but same result, only showing ten drivers.

What is the meaning of "Leader Standing Lines" and "Target Standings Lines"

Edit: ok now I have two (how do you call it?) arrays of drivers showing 15 drivers. Have to play some more with these settings I Think :)

Michel-NL commented 7 years ago

New race video and data with 15 drivers. Leader Standing lines 0 Target Standings lines 15

Now its showing 15 drivers 👍

SenorPez commented 7 years ago

Hmm... I'll take a look at this. I'm also going to fix the defaults so they don't break old videos... that's not good behavior on my part.

The intended result is this: The "Standings List" that gets overlayed on the video has two parts:

Example uses:

I'll run your data through... leader_window_size 11 SHOULD catch everyone, but if it's not, something's going on. I think I have an inkling of what that might be if it's broken, though.

Michel-NL commented 7 years ago

Aha nice feature :) Could you put this on the wiki?

What if I wanted to show all drivers, could I use 0 for both settings? With 16 drivers I want them all on the Standings List.

Michel-NL commented 7 years ago

I'll run your data through... leader_window_size 11 SHOULD catch everyone, but if it's not, something's going on. I think I have an inkling of what that might be if it's broken, though.

Let my first create an -s video. Because I didn't placed the settings at all in the config file.

Michel-NL commented 7 years ago

Settings used "field_window_size" : 11, "leader_window_size" : 0,

Gives me 11 drivers so thats ok for me, because the race has 11 drivers.

SenorPez commented 7 years ago

Changed the defaults for "result_lines" and "leader_window_size" to 16 and "field_window_size" to 0. Using these settings seems to render the video correctly.