search

SenorPez / project-cars-replay-enhancer

Project CARS Replay Enhancer: Combines telemetry data with replay video to improve Project CARS replays.
MIT License
12 stars 1 forks source link

Players disconnecting in race are not in the final results #112

Closed Michel-NL closed 7 years ago

Michel-NL commented 7 years ago

I don't know if you wanted it to be this way, but drivers who disconnect from the race are not showing up on the results screen. aor gt3 pro league - round 3 - road america replay _starting_grid aor gt3 pro league - round 3 - road america replay _results

SenorPez commented 7 years ago

No, they should still show up in the results!

Michel-NL commented 7 years ago

They also disappear from the standings list in the overlay. In lap 7 the driver Wimstradamus disconnect https://youtu.be/LPtWFRucK6g

SenorPez commented 7 years ago

That's as planned. Drivers who drop out of the race slide out (to the left) of the standings. But they should still show up in the final standings.

SenorPez commented 7 years ago

Turns out they do show up. I tested it with a few datasets and they properly list into the final results.

What's probably happening is another bad default by me. Check your configuration file; there's a key called result_lines that's probably set to 10. Set that to a larger number to control the number of lines shown on the cards.

I've changed the default to a more reasonable number of 16 (from 10) in another check-in.

SenorPez commented 7 years ago

Never mind, I see the problem now. Still an issue.

SenorPez commented 7 years ago

@Michel-NL Can you try this with your dataset to confirm it works? It works with the test data I have. Thanks!

Michel-NL commented 7 years ago

I will try it later this day.

Michel-NL commented 7 years ago

If I do pip install --upgrade replayenhancer I don't get an upgrade for the code. Or should it work with the version I have?

SenorPez commented 7 years ago

Sorry about that. I meant to publish a release candidate to the repository, but ran out of time! It should publish out tonight if everything builds correctly.

SenorPez commented 7 years ago

It's published. Note that, due to pip's algorithms, you'll need to specify the Release Candidate specifically.

pip install replayenhancer==0.5.1rc1

Note the 2 = signs.

Michel-NL commented 7 years ago

It's working now. Good job!