Senryoku / Draftmancer

Multiplayer MTG Limited Simulator
https://draftmancer.com
MIT License
86 stars 32 forks source link

Seeing your own draft log #321

Closed sprangg closed 2 years ago

sprangg commented 2 years ago

Currently the "Owner only, delayed" mode is great for log sharing in traditional draft tournaments where you don't know the decks of your opponents beforehand. However, it'd be useful to still be able to see your own log before the session owner unlocks all the logs. I can't think of a reason why it'd be necessary to block one from seeing their own log.

Senryoku commented 2 years ago

I think you have a point. However I feel like some might think being able to review every single pick after the fact would be too much information (Even if you could technically write them down). What do you think about giving access only to your final card pool (useful to retrieve it easily if you leave the page), not the picks? Or were you specifically asking about the picks too?

sprangg commented 2 years ago

Yeah I was asking about the picks and not particularly interested in seeing the final decklist there. Our group (XDHS) usually drafts with Xmage and there your draftlog is available at all times - you can even see your incomplete log during the drafting. This has never been any issue.

I'm not asking for the log to be visible during drafting but seeing the full log right afterwards without the host unlocking everything would be nice. This could also exist as its own mode perhaps, if you don't want to change the "Owner only, delayed" mode. Something like "Personal only, delayed".

And that brings another idea to mind - in this mode it could be so that even the owner doesn't see all the logs until they unlock them. It'd remove the information-asymmetry where the session owner is able to see the logs before they're unlocked. (Of course we can usually assume the host to be a trustworthy person who doesn't peek, but it'd still be a nice fair and consistent option imo.)

Senryoku commented 2 years ago

And that brings another idea to mind - in this mode it could be so that even the owner doesn't see all the logs until they unlock them. It'd remove the information-asymmetry where the session owner is able to see the logs before they're unlocked. (Of course we can usually assume the host to be a trustworthy person who doesn't peek, but it'd still be a nice fair and consistent option imo.)

That's how the "Owner only, delayed" setting works :) (at least it should, file a bug if it's not the case!)

Alright, thanks for the precision, I'll see what I can do!

tooomm commented 2 years ago

That's how the "Owner only, delayed" setting works :) (at least it should, file a bug if it's not the case!)

Owner = player then? I also thought owner means the room owner and game host... 🙈

sprangg commented 2 years ago

"Owner only, delayed" works so that nobody sees the logs until the session owner clicks a button that makes the logs visible to everyone. I just confirmed with bots. So works as intended, and good that it works this way!

I thought it didn't work this way because of some strangeness in our draft yesterday where it appeared all the logs were only visible to the owner and not the others. I'll try to find out exactly what happened and make a new issue if I figure it out and it's an actual unintended behavior. Maybe the host accidentally used the "Owner only" mode instead.

Senryoku commented 2 years ago

That's how the "Owner only, delayed" setting works :) (at least it should, file a bug if it's not the case!)

Owner = player then? I also thought owner means the room owner and game host... 🙈

Yeah, it means the session owner, I agree the name is misleading. It stems for the fact that only the owner receive the full (locked) logs so they can share them later (Logs are only stored temporarily on the server side), and also that the feature changed multiple times. I can probably rename it: Would simply "Delayed" be good enough?

sprangg commented 2 years ago

I agree that it's a bit misleading, part of what led me to believe that the owner was able to see the logs before the other players. Just "delayed" sounds good to me.

And maybe something like "Personal + delayed" could be the name of the mode where you see your own log before you see everyone else's. (If it's a separate mode)

tooomm commented 2 years ago

Current state: Send game logs to: Everyone / Owner only / Owner only, delayed / No-one Which uses the unclear term "owner", and "delayed" might also not be self-explanatory as well. Delayed until the draft ended? Delayed for 15min?

What about: Game logs: Complete (everybody) / Complete (everybody after host approval) / Complete (host only) / Disabled

The new options could be: Personal (everybody) and Personal (everybody) + Complete (after host approval)

Keep in mind that ordinary users are not aware of who is owning which data in the app concept and what a session is. Those are rather technical terms and should be represented differently in the UI.

I know there are some explaining pop ups, but they happen to show quite far away from some options, so they can easily be missed.

Senryoku commented 2 years ago

"Session owner" should be used throughout the application, I'll keep using this term.

Keep in mind that ordinary users are not aware of who is owning which data in the app concept and what a session is. Those are rather technical terms and should be represented differently in the UI.

I agree completely, the current name is more a leftover than a conscious decision.

Your list is a little too long for my taste, I'm not sure if I want Personal to be a separate option yet.

sprangg commented 2 years ago

There's a tooltip that tells what the "Owner only, delayed" mode does. I agree that based simply on the name it's hard to decipher but the tooltip tells all that's needed. 2022-05-28 13_33_55-Window

Edit: Inability to fully read before replying strikes again, you did have this as your last sentence tooomm "I know there are some explaining pop ups, but they happen to show quite far away from some options, so they can easily be missed."

The tooltip is a bit far indeed but noticeable enough imo and a sufficient explanation.

Senryoku commented 2 years ago

I'm leaning towards these options (notice the "full" game logs): image With this tooltip: image

Personal logs would always be accessible, even when 'No-one' is selected here.

sprangg commented 2 years ago

Looks great to me! And the "owner approval" mode is now named so that you can understand what's going on from the mode's name.

sprangg commented 2 years ago

Ok, sadly I have to say I just discovered a downside to personal logs being available at all times: Team drafts.

If the participants' personal logs are available to team drafters, the team can pool their logs after the draft and deduce all the picks of their opponents, apart for their first picks from packs. This doesn't seem like a good thing for the health of the format.

What do you think would be a good solution? In my opinion the personal logs should be excluded from team drafts, but this would of course introduce an inconsistency.

Senryoku commented 2 years ago

Since it's theoretically possible for players to write down each pick manually, I'd say it's not a huge issue, but I agree that it's more obvious in team draft. Rather than silently disabling personal logs in team draft, I'd add another, separate, setting to explicitly disable them. It also has the advantage of making every option listed by @tooomm possible, while being somewhat simpler imo. image

sprangg commented 2 years ago

That's a great solution that should solve every problem situation!

tooomm commented 2 years ago

Your list is a little too long for my taste

I know, I could not come up with shorter terms that are self speaking and on point. I used a shorter label to mitigate this a bit.

That looks good and is definitely an improvement. I still don't think "owner" is obvious for "session owner". Users probably think of "owner of the logs" aka each player in this context first, but I get your point.


Not a fan of private logs. But as long as they can be disabled in normal drafts as well, it's ok IMHO.


There's a tooltip that tells what the "Owner only, delayed" mode does. I agree that based simply on the name it's hard to decipher but the tooltip tells all that's needed. The tooltip is a bit far indeed but noticeable enough imo and a sufficient explanation.

On big screens it can be quite far away, but the main point is that a tooltip should not be mandatory to correctly understand certain options.

Senryoku commented 2 years ago

I have a first version available here: https://mtgadraftbeta.herokuapp.com/ I'd be grateful if you could give it a test and report any bugs or concern you may have with it.

sprangg commented 2 years ago

Thanks, works great for the most part! We'll be doing a test draft with the "Everyone, on owner approval" mode in a few minutes, with personal logs enabled. Update: Test draft went without problems.

Here's the results of my quick testing:

Edit: The empty log isn't of course necessarily a bug, just a changed functionality. It could be nice to see who you drafted with and the seating order from the log, even if there are no picks to show.

tooomm commented 2 years ago

I'd be grateful if you could give it a test and report any bugs or concern you may have with it.

Quick feedback:

I did not test the various combinations.

Senryoku commented 2 years ago

Thanks for the feedback.

I wasn't too sure what to do about the download button, it will now be disabled for not-yet-shared logs.

I choose to change the behavior slightly to always have a log, even it doesn't hold any card information. It's more consistent, lets you keep a trace of your games and more importantly allows players to share their decks there (only the hashes if they don't have access to the full log).

  • Disabling private logs and changing the setting to Everyone, on owner approval is not remembered. Every time I load the page, it's back to defaults.

It's the case for every session related setting, I agree there's possible improvements here, but this is another topic.

sprangg commented 2 years ago

Since the download button is disabled now until the logs are unlocked, I'll be closing this! Many thanks for the implementation!