Remeber settings between sessions

Senryoku / Draftmancer

Multiplayer MTG Limited Simulator

https://draftmancer.com

MIT License

86 stars 32 forks source link

Remeber settings between sessions #323

Closed tooomm closed 2 years ago

tooomm commented 2 years ago

Game settings are not saved and are lost when reloading the site. There are certain settings that the host always has to adjust according to his playgroup or personal preferences, e.g. log distribution.

App settings like disabled sound or enabled pick on double click are saved already.

Senryoku commented 2 years ago

eb94f5207390a0e2d09704dd97df593e6abc41c2 Saves a subset of the session settings to be reapplied automatically when the user create a new session. See the list of saved settings bellow. I limited it to settings that are relevant to the personal preferences for the user, not to a particular game mode. Is there other settings I should include?
b9a4eb26f240981f5f404abda64a11f9b057356a Adds a reset session settings button (I felt like this was necessary with the previous change)

Theses patches can be tested at https://mtgadraftbeta.herokuapp.com/

Currently saved session settings:

randomizeSeatingOrder
disableBotSuggestions
maxTimer
ignoreCollections
foil
personalLogs
draftLogRecipients

tooomm commented 2 years ago

I think you covered the important pieces. 👍 The reset is also nice, and the narrower settings window with the more visible tooltips.

Players do not enter a fresh session now when going to the side, though. It's remembered as well. But that seems to be only an issue on beta.

Senryoku commented 2 years ago

Players do not enter a fresh session now when going to the side, though. It's remembered as well. But that seems to be only an issue on beta.

Sorry, I don't understand, what's the problem?

tooomm commented 2 years ago

Nevermind. It was due to my test browser not having custom values set and it received new random user names and new random session id's on every reconnect. As soon as you change the session id (append a random character for example), you'll always rejoin/reopen that same session when entering the page - even via the default URL with no session id attached. I did not understand right away why it's not giving me new values suddenly.