SenseNet / sn-admin

Upgrade and package executor tool for sensenet.
https://sensenet.com
GNU General Public License v2.0
0 stars 2 forks source link

Cleanup package folder #16

Closed tusmester closed 6 years ago

tusmester commented 7 years ago

The algorithm of executing packages allows you to provide a package name without the (zip) extension. This is useful, because it lets us have packages as folders, without a zip file - take Admin\tools for example, a container that contains built-in tool folders, not zip files.

The problem with the current behavior is that if there is a zip file and a folder with the same name, SnAdmin uses the folder, even if the zip package is newer. This leads to a confusing install process (for example when we update a nuget package to a newer version that contains a new zip package).

Solution: if you execute the package with a name (without extension) and there is a zip file there, we should always execute the zip file. If a folder is there from a previous execution, than delete it before the operation.

tusmester commented 7 years ago

This deserves a releasebloccker label because we should solve it before going stable with the main components.

kavics commented 7 years ago

Agree