SenseNet / sn-client

Monorepo for sensenet client packages 🐱‍💻
https://sensenet.com
GNU General Public License v2.0
25 stars 37 forks source link

Encoding filename in Content-Disposition header #1596

Closed hashtagnulla closed 6 months ago

hashtagnulla commented 7 months ago

Previously, when a user tried to upload a file that's filename included non-ascii characters, the frontend couldn't build the header and the process was interrupted. Now it's fixed :)

CLAassistant commented 7 months ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Nagy Viktor seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (e194979) 92.47% compared to head (6b1f420) 92.47%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #1596 +/- ## ======================================== Coverage 92.47% 92.47% ======================================== Files 253 253 Lines 7149 7149 Branches 1937 1937 ======================================== Hits 6611 6611 Misses 538 538 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sensenet[bot] commented 7 months ago
Site name Url Last deploy
sn-react-component-docs-dev https://65cd27e3017c590c571e17ec--sn-react-component-docs-dev.netlify.app Wed Feb 14 2024 - 20:51:47 GMT+0000 (Coordinated Universal Time)
sn-app-dev https://65cd27df7769f221c30d15c0--sn-app-dev.netlify.app Wed Feb 14 2024 - 20:51:46 GMT+0000 (Coordinated Universal Time)