gallayl commented 5 years ago

🐜 Bug Report

Error navigating upwards if the parent doesn't have a Workspace reference expanded

📦 Package / Application

pickers-react

📃 Version

@latest dev

🐜 Describe the bug

when you try to navigate upwards to a content with no Workspace ref expanded, it won't do anything. There's also some unhandled null checks.

👉 Steps To Reproduce

Go to the Admin UI
Navigate to a subfolder
Select an item
Select "Copy" from the context menu
Try to navigate upwards. You won't be able to navigate to the parent, if it has no Workspace reference.
😯 Current behavior

You will also get an error on the console:

Uncaught TypeError: Cannot read property 'Id' of null
    at setParentIdOnDoubleClick (webpack-internal:///../../packages/sn-pickers-react/dist/ListPicker/ListPicker.js:77)
    at Object.onItemDoubleClickHandler [as onDoubleClickHandler] (webpack-internal:///../../packages/sn-pickers-react/dist/ListPicker/ListPicker.js:63)
    at onDoubleClick (webpack-internal:///../../packages/sn-pickers-react/dist/ListPicker/Item.js:17)
    at HTMLUnknownElement.callCallback (webpack-internal:///../../node_modules/react-dom/cjs/react-dom.development.js:149)
    at Object.invokeGuardedCallbackDev (webpack-internal:///../../node_modules/react-dom/cjs/react-dom.development.js:199)
    at invokeGuardedCallback (webpack-internal:///../../node_modules/react-dom/cjs/react-dom.development.js:256)
    at invokeGuardedCallbackAndCatchFirstError (webpack-internal:///../../node_modules/react-dom/cjs/react-dom.development.js:270)
    at executeDispatch (webpack-internal:///../../node_modules/react-dom/cjs/react-dom.development.js:561)
    at executeDispatchesInOrder (webpack-internal:///../../node_modules/react-dom/cjs/react-dom.development.js:580)
    at executeDispatchesAndRelease (webpack-internal:///../../node_modules/react-dom/cjs/react-dom.development.js:680)

🤔 Expected behavior

I think you should be able to navigate up by default if you can load the parent content.
If the app developer wants to limit this functionality (e.g. allow browsing only under a specific workspace or a content with a specification) it should be set up on a prop (e.g. a canSetParent: (parent: GenericContent) => boolean callback)

🖼 Screenshots

💻 Code sample (for developers)

https://github.com/SenseNet/sn-client/blob/01708dcb33000308f3e32007012395730c61e3cc/packages/sn-pickers-react/src/ListPicker/ListPicker.tsx#L81

🌍 Your Environment (for developers)

Software	Version(s)
Language (js/ts)	ts
Operating System	win10
NPM/Node/Yarn	yarn
Bundler	webpack

🌍 Your environment (for apps / examples)

a frying pan

🗨 Additional context

kultsar commented 5 years ago

From context menu seems ok. If Copy is started from the Actions menu, however, the user still cannot access parent folder.