search

SenseNet / sn-controls-aurelia

Aurelia controls for sensenet ECM
GNU General Public License v2.0
2 stars 0 forks source link

An in-range update of aurelia-router is breaking the build 🚨 #25

Closed greenkeeper[bot] closed 6 years ago

greenkeeper[bot] commented 6 years ago

Version 1.4.0 of aurelia-router just got published.

Branch Build failing 🚨
Dependency aurelia-router
Current Version 1.3.0
Type dependency

This version is covered by your current version range and after updating it in your project the build failed.

aurelia-router is a direct dependency of this project this is very likely breaking your project right now. If other packages depend on you it’s very likely also breaking them. I recommend you give this issue a very high priority. I’m sure you can resolve this :muscle:

Status Details - ❌ **continuous-integration/travis-ci/push** The Travis CI build failed [Details](https://travis-ci.org/SenseNet/sn-controls-aurelia/builds/282094459?utm_source=github_status&utm_medium=notification)
Release Notes 1.4.0

aurelia-router 1.4.0

Bug Fixes

  • activation: Deactivate child viewModels when replacing a parent (f73b6d5)
  • router: fix NavigationInstructionInit's queryParams (1266b0b)
  • router: getBaseUrl() to return correct URL for encodable chars (0ef12f6)

Features

  • activation: call can/Deactivate with navigationInstructions (3d3c444), closes #493
  • router: enable parent chain unknown route handlers (f692bcb)
  • type declarations: Refine the type (638aef4)
Commits

The new version differs by 44 commits.

  • dffe907 chore(all): prepare release 1.4.0
  • f3755a8 chore(all): fix lint errors
  • 39c1fbe Merge pull request #521 from gheoan/catch-all-handler-query
  • 16f9205 Merge pull request #519 from gheoan/test-promise-catch
  • 9c78465 Merge pull request #516 from gheoan/activation-strategy-docs
  • 0e3937c Merge pull request #514 from shahabganji/master
  • 1266b0b fix(router): fix NavigationInstructionInit's queryParams
  • 9800bb5 test(router): fix promise catch logging
  • d90406e doc(activation-strategy): improve activation strategy doc
  • 0d21fe2 doc( router.isNavigating ) added some description
  • a398f55 Merge pull request #474 from jagonalez/unknown-route
  • c93e1ad Merge pull request #512 from davismj/master
  • c5aac22 Merge branch 'feature/deactivate-with-navigation-instructions'
  • dc146bb Merge pull request #511 from davismj/master
  • 5776f9a Fix: Fix broken test

There are 44 commits in total.

See the full diff

Not sure how things should work exactly? There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html) and of course you may always [ask my humans](https://github.com/greenkeeperio/greenkeeper/issues/new).

Your Greenkeeper Bot :palm_tree:

greenkeeper[bot] commented 6 years ago

After pinning to 1.3.0 your tests are still failing. The reported issue might not affect your project. These imprecisions are caused by inconsistent test results.