search

SenseNet / sn-webpages

UI layer for the sensenet platform built using ASP.NET pages, webparts and controls.
https://www.sensenet.com/
GNU General Public License v2.0
5 stars 8 forks source link

PRC can blow up the whole page #9

Open tusmester opened 6 years ago

tusmester commented 6 years ago

If something goes wrong in the DisplayInformation method in PortalRemoteControl.cs (for example an incorrect format string is used), the whole page becomes inaccessible.

Source code

https://github.com/SenseNet/sn-webpages/blob/8619346e48155b4501cf21a3ab7fdfc9b0559868/src/WebPages/UI/Controls/PortalRemoteControl.cs#L346

Solution

Make this method more robust by placing try-catch blocks around risky parts.

subhamX commented 4 years ago

@herflis Can I work on this? Also please tell me if I need to only wrap risky parts in try-catch block only? Or something else. :)