Closed SensehacK closed 4 years ago
Changelog:
Dynamic UI screen allotment.
Removed "Main" storyboard links from Info Plist
Moved code from App delegate / View controller -> Scene delegate
Storyboard Identifier assigned.
Also Portrait Only support right now.
Added comments regarding this big change of code flow at every app launch.
Moved Analytics initializer in new function so no return object callback. (Silenced the Xcode empty returned object warning)
Please check if the PR fulfills these requirements
Code Style
[x] The commit message follows our guidelines
[x] My code follows the code style of this project.
[x] I have read the CONTRIBUTING document.
[ ] Fixed merge conflicts with Master branch as base.
Documentation
[ ] My change requires a change to the documentation.
[ ] Docs have been added / updated (for bug fixes / features)
[x] I have updated the documentation accordingly.
Tests
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.
[ ] Tests for the changes have been added (for bug fixes / features)
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
[x] New feature (non-breaking change which adds functionality)
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
Relevant Issues
Fixes #53
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
[ ] Github Actions
[ ] Travis CI
Checklist
[x] Compiles and passes lint tests
[x] Properly formatted
[ ] Tested on Desktop
[x] Tested on iPhone
[ ] Tested on Android
[ ] Tested on Apple Watch
[x] Tested on Xcode Simulator
[ ] Tested on Simulator
Screenshots
Other information:
Changelog:
Dynamic UI screen allotment.
Removed "Main" storyboard links from Info Plist
Moved code from App delegate / View controller -> Scene delegate
Storyboard Identifier assigned.
Also Portrait Only support right now.
Added comments regarding this big change of code flow at every app launch.
Moved Analytics initializer in new function so no return object callback. (Silenced the Xcode empty returned object warning)
Please check if the PR fulfills these requirements
Code Style
[x] The commit message follows our guidelines
[x] My code follows the code style of this project.
[x] I have read the CONTRIBUTING document.
[ ] Fixed merge conflicts with Master branch as base.
Documentation
[ ] My change requires a change to the documentation.
[ ] Docs have been added / updated (for bug fixes / features)
[x] I have updated the documentation accordingly.
Tests
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.
[ ] Tests for the changes have been added (for bug fixes / features)
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
[x] New feature (non-breaking change which adds functionality)
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
Relevant Issues
Fixes #53
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
[ ] Github Actions
[ ] Travis CI
Checklist
[x] Compiles and passes lint tests
[x] Properly formatted
[ ] Tested on Desktop
[x] Tested on iPhone
[ ] Tested on Android
[ ] Tested on Apple Watch
[x] Tested on Xcode Simulator
[ ] Tested on Simulator
Screenshots
Other information: