SensehacK / health-sense

All in one Health App - Computer Science Capstone Project
https://sensehack.github.io/health-sense/
GNU General Public License v2.0
8 stars 3 forks source link

(Style) Settings Revamp #59

Closed SensehacK closed 4 years ago

SensehacK commented 4 years ago

Pull Request

Settings Screen v.0.3 vs v.0.4

Description

Settings Revamped. More control to the user. API: Programmer Quotes For full details please check the change log at the end.

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Code Style

Documentation

Tests

Behavior

Fixes #52

What is the current behavior? (You can also link to an open issue here) Settings Old implementation

Screen Shot 5

What is the new behavior (if this is a feature change)? New settings screen implementation.

Light Mode Dark Mode
Screen Shot 2020-05-11 at 7 55 15 PM Screen Shot 2020-05-11 at 7 54 22 PM

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

Tested Checklist

Other information

Additional context/Screenshots Add any other context about the problem here. If applicable, add screenshots to help explain.

Note: for PR Review This repository's PRs would be peer reviewed and then 1 approving reviewer is needed to merge code with master branch.

Changelog

Settings Related changelog

Other

Universal Dark Mode added

Learnt

codecov-io commented 4 years ago

Codecov Report

Merging #59 into master will increase coverage by 0.07%. The diff coverage is 6.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #59      +/-   ##
==========================================
+ Coverage   11.31%   11.38%   +0.07%     
==========================================
  Files          29       29              
  Lines         716      817     +101     
==========================================
+ Hits           81       93      +12     
- Misses        635      724      +89     
Impacted Files Coverage Δ
...nse/Controller/Main/HealthBookViewController.swift 0.00% <0.00%> (ø)
...Sense/Controller/Main/SettingsViewController.swift 0.00% <0.00%> (ø)
...hSense/Controller/Main/SummaryViewController.swift 0.00% <0.00%> (ø)
...hSense/HealthSense/Helper/Healthkit/ReadBody.swift 0.00% <ø> (ø)
...S/HealthSense/HealthSense/Utilities/Settings.swift 51.42% <57.14%> (-0.30%) :arrow_down:
...ler/Onboarding/FirstOnboardingViewController.swift 100.00% <100.00%> (ø)
...S/HealthSense/HealthSense/Main/SceneDelegate.swift 61.90% <100.00%> (+0.92%) :arrow_up:
...nse/HealthSense/Helper/Healthkit/ReadProfile.swift 10.81% <0.00%> (+10.81%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6771ea6...9fd645c. Read the comment docs.