SGA-60: Refactor 'SmartgadgetPreferenceFragment'

Sensirion / SmartGadget-Android

Deprecated and not maintained anymore. The Sensirion Smart Gadget app allows you to establish a BLE (Bluetooth Low Energy) connection to your Sensirion Smart Gadget. The app displays the current temperature and relative humidity values measured by the integrated sensors.

BSD 3-Clause "New" or "Revised" License

30 stars 15 forks source link

SGA-60: Refactor 'SmartgadgetPreferenceFragment' #10

Closed xavier-fernandez closed 8 years ago

xavier-fernandez commented 8 years ago

Bind XML strings using the BUTTERKNIFE library
Refactor de preference adapter to use the ViewHolder pattern
Prefer ‘getContext()’ rather than ‘getParent()’ whether possible
Rename all prefix named ‘obtain’ to ‘get’ in order to follow project conventions
Refactor code for avoiding lines with a length greater than 120 characters
Avoid some possible NullPointerExceptions if the parent activity is not a ‘MainActivity’. (Logs an error instead)

xavier-fernandez commented 8 years ago

@abrauchli I did an amend to the commit

xavier-fernandez commented 8 years ago

@abrauchli Did an amend fixing the following issues:

Replace asserts with if(whatever != null)
Obtain typeface from XML
Fix small issue with the XML name

xavier-fernandez commented 8 years ago

Did an amend cb0ee5d...44540bf

Previous commit: https://github.com/xavier-fernandez/SmartGadget-Android/commit/cb0ee5d964331d19e322fd35de9a83cc2f7bb385

abrauchli commented 8 years ago

merged in master