search

Sensirion / SmartGadget-Android

Deprecated and not maintained anymore. The Sensirion Smart Gadget app allows you to establish a BLE (Bluetooth Low Energy) connection to your Sensirion Smart Gadget. The app displays the current temperature and relative humidity values measured by the integrated sensors.
BSD 3-Clause "New" or "Revised" License
30 stars 15 forks source link

SGA-61: Fix 'not-running test' bug #8

Closed xavier-fernandez closed 8 years ago

xavier-fernandez commented 8 years ago
abrauchli commented 8 years ago

Code seems fine, test doesn't pass (seems unrelated) gradle connectedAndroidTest

com.sensirion.smartgadget.tests.ui.view.XyPlotViewComfortZoneSummerTest > testComfortZoneCorners[GT-I9505 - 4.4.2] FAILED 
    junit.framework.AssertionFailedError
    at com.sensirion.smartgadget.tests.ui.view.XyPlotViewComfortZoneTest.testComfortZoneCorners(XyPlotViewComfortZoneTest.java:28)

com.sensirion.smartgadget.tests.ui.view.XyPlotViewComfortZoneSummerTest > testComfortZoneInsideBottomLeft[GT-I9505 - 4.4.2] FAILED 
    junit.framework.AssertionFailedError
    at com.sensirion.smartgadget.tests.ui.view.XyPlotViewComfortZoneTest.testComfortZoneInsideBottomLeft(XyPlotViewComfortZoneTest.java:56)

com.sensirion.smartgadget.tests.ui.view.XyPlotViewComfortZoneSummerTest > testComfortZoneInsideMid[GT-I9505 - 4.4.2] FAILED 
    junit.framework.AssertionFailedError
    at com.sensirion.smartgadget.tests.ui.view.XyPlotViewComfortZoneTest.testComfortZoneInsideMid(XyPlotViewComfortZoneTest.java:70)

com.sensirion.smartgadget.tests.ui.view.XyPlotViewComfortZoneSummerTest > testComfortZoneInsideTopRight[GT-I9505 - 4.4.2] FAILED 
    junit.framework.AssertionFailedError
    at com.sensirion.smartgadget.tests.ui.view.XyPlotViewComfortZoneTest.testComfortZoneInsideTopRight(XyPlotViewComfortZoneTest.java:62)

com.sensirion.smartgadget.tests.ui.view.XyPlotViewComfortZoneSummerTest > testComfortZoneOutsideBottomRight[GT-I9505 - 4.4.2] FAILED 
    junit.framework.AssertionFailedError
    at com.sensirion.smartgadget.tests.ui.view.XyPlotViewComfortZoneTest.testComfortZoneOutsideBottomRight(XyPlotViewComfortZoneTest.java:48)

com.sensirion.smartgadget.tests.ui.view.XyPlotViewComfortZoneSummerTest > testComfortZoneOutsideTopLeft[GT-I9505 - 4.4.2] FAILED 
    junit.framework.AssertionFailedError
    at com.sensirion.smartgadget.tests.ui.view.XyPlotViewComfortZoneTest.testComfortZoneOutsideTopLeft(XyPlotViewComfortZoneTest.java:38)

com.sensirion.smartgadget.tests.ui.view.XyPlotViewComfortZoneSummerTest > testComfortZoneOutsideZero[GT-I9505 - 4.4.2] FAILED 
    junit.framework.AssertionFailedError
    at com.sensirion.smartgadget.tests.ui.view.XyPlotViewComfortZoneTest.testComfortZoneOutsideZero(XyPlotViewComfortZoneTest.java:75)

com.sensirion.smartgadget.tests.ui.view.XyPlotViewComfortZoneWinterTest > testComfortZoneOutsideBottomRight[GT-I9505 - 4.4.2] FAILED 
    junit.framework.AssertionFailedError
    at com.sensirion.smartgadget.tests.ui.view.XyPlotViewComfortZoneTest.testComfortZoneOutsideBottomRight(XyPlotViewComfortZoneTest.java:48)

com.sensirion.smartgadget.tests.ui.view.XyPlotViewComfortZoneWinterTest > testComfortZoneOutsideTopLeft[GT-I9505 - 4.4.2] FAILED 
    junit.framework.AssertionFailedError
    at com.sensirion.smartgadget.tests.ui.view.XyPlotViewComfortZoneTest.testComfortZoneOutsideTopLeft(XyPlotViewComfortZoneTest.java:38)

com.sensirion.smartgadget.tests.ui.view.XyPlotViewComfortZoneWinterTest > testComfortZoneOutsideZero[GT-I9505 - 4.4.2] FAILED 
    junit.framework.AssertionFailedError
    at com.sensirion.smartgadget.tests.ui.view.XyPlotViewComfortZoneTest.testComfortZoneOutsideZero(XyPlotViewComfortZoneTest.java:75)

com.sensirion.smartgadget.tests.ui.view.XyPlotViewGridTest > testCorners[GT-I9505 - 4.4.2] FAILED 
    junit.framework.AssertionFailedError
    at com.sensirion.smartgadget.tests.ui.view.XyPlotViewGridTest.testCorners(XyPlotViewGridTest.java:33)

com.sensirion.smartgadget.tests.ui.view.XyPlotViewGridTest > testOutsideGrid[GT-I9505 - 4.4.2] FAILED 
    junit.framework.AssertionFailedError
    at com.sensirion.smartgadget.tests.ui.view.XyPlotViewGridTest.testOutsideGrid(XyPlotViewGridTest.java:46)
:app:connectedDebugAndroidTest FAILED
xavier-fernandez commented 8 years ago

@abrauchli that test do not pass, these test already failed when I arrived to Sensirion.

That test are not related to this PR.

abrauchli commented 8 years ago

I see. The goal (ticket) is still to have them fixed, if possible. Let's put it off until after the refactoring, then I'll merge this and the new commit (it's a good idea to keep them separate commits on the same branch since this is already reviewed)

abrauchli commented 8 years ago

Following discussion, merged as b4fcdc4