Sensirion / embedded-common

Generic Embedded i2c Driver HAL / Common Files
BSD 3-Clause "New" or "Revised" License
30 stars 16 forks source link

Check if execution of command failed #79

Closed Zifzaf closed 3 years ago

Zifzaf commented 3 years ago

Fix the handling of execution errors when using the SHDLC protocol. Now execution errors reported in the state byte result in a error.

rnestler commented 3 years ago

I'd just merge master back into driver-generator/main once #78 is merged.

Edit: Reason: It will make merging driver-generator/main back into master easier at a later point.

Zifzaf commented 3 years ago

Agreed but there is one change here which won't be added by this. Should I just remove the rest? Or what should we do?

rnestler commented 3 years ago

Agreed but there is one change here which won't be added by this. Should I just remove the rest? Or what should we do?

When creating the merge request to merge master, add the additionally needed change on a separate commit. See #73.

Zifzaf commented 3 years ago

Replaced by https://github.com/Sensirion/embedded-common/pull/80