Sensirion / embedded-sps

Embedded i2c Driver for Sensirion Particulate Matter Sensors - Download the Zip Package from the Release Page
https://github.com/Sensirion/embedded-sps/releases
BSD 3-Clause "New" or "Revised" License
45 stars 15 forks source link

Update README with link to Arduino project #39

Closed abrauchli closed 4 years ago

abrauchli commented 4 years ago

Add a link to the arduino project to the readme

Fixes https://github.com/Sensirion/embedded-sps/issues/14

Check the following:

rnestler commented 4 years ago

@abrauchli Can you tick off the stuff not applicable in the check list? Otherwise it looks like you still need to verify that it doesn't contain breaking changes, etc.

abrauchli commented 4 years ago

@abrauchli Can you tick off the stuff not applicable in the check list? Otherwise it looks like you still need to verify that it doesn't contain breaking changes, etc.

we should discuss this as I'm not comfortable with someone checking off items that weren't done. E.g. "tested on actual hardware" if it wasn't actually done - that shouldn't block the merging (esp. when documentation was updated), but then the reviewer is not under the impression that it was actually tested. Then I'd rather the item be deleted instead of checked.

rnestler commented 4 years ago

Then I'd rather the item be deleted instead of checked.

:+1: Or marked as not applicable by striking through or whatever. Exeamples: