SHDLC: Separate error value for too long frames

Sensirion / embedded-uart-sps

Embedded UART Driver for Sensirion Particulate Matter Sensors - Download the Zip Package from the Release Page

BSD 3-Clause "New" or "Revised" License

44 stars 24 forks source link

Closed abrauchli closed 4 years ago

abrauchli commented 4 years ago

Better error handling when decoding incorrect SHDLC frames:

Add a new error constant SENSIRION_SHDLC_ERR_FRAME_TOO_LONG which is returned when the frame contains more data than expected (the length field)
When a CRC is supplied, it is now checked before checking if the frame is too long, causing the exit path (CRC error) to be backtraceable.

Check the following:

rnestler commented 4 years ago

Breaking changes marked in commit message

While an added error value may be considered a breaking change, I wouldn't call it breaking, since we make no guarantee about it.

abrauchli commented 4 years ago

Update changelog?

done