search

SenteraLLC / ulabel

A browser-based tool for image annotation
MIT License
23 stars 5 forks source link

Initial global edit suggestion construction #184

Closed joshua-dean closed 1 month ago

joshua-dean commented 1 month ago

https://github.com/SenteraLLC/ulabel/blob/fe138c883f65d06d8d37cb19064c16bebb2a0cae/src/html_builder.ts#L542-L549

ulabel.subtasks[ulabel.state["current_subtask"]]["active_annotation"] should be type ULabelAnnotation, so displaying the whole thing doesn't make sense.

In update_confidence_dialog: https://github.com/SenteraLLC/ulabel/blob/fe138c883f65d06d8d37cb19064c16bebb2a0cae/src/index.js#L6250-L6260 It does a proper loop to actually display the maximum confidence.

I don't think this causes any display issues, but it left me scratching my head when I ran into it.

joshua-dean commented 1 month ago

Removing the content of that <p> tag in the initial build function doesn't seem to hurt any functionality.