search

Senth / MaterialShowcaseView

A Material Design themed ShowcaseView for Android
Apache License 2.0
6 stars 6 forks source link

Overlay over DialogFragment #5

Open rafalzawadzki opened 7 years ago

rafalzawadzki commented 7 years ago

I have tried using the showcase over a custom DialogFragment, but unfortunately it appears under the popup. It may be caused by the activity passed into the Builder instead of dialog context. Do you have any idea how to accomplish this?

Senth commented 7 years ago

Hi, If I have time I might look into it tomorrow, otherwise on Tuesday. :)

If you can't wait—I know the feeling of waiting for a bug to be fixed—and come up with a solution please submit it either as a pull request or here in a comment here :)

Senth commented 7 years ago

The problem seems to be that dialogs adds their layout a bit differently. I haven't found a solution yet and I have to continue with my own work for now.

What you could do is to clone a local copy of this repository. I've added another example with an alert dialog popup in Target Example. So if you can make that example work it's solved.

You should only have to change the _showNow() method in MaterialShowcaseView.java.

I found some suggestions here: http://stackoverflow.com/a/29436889/1412681 that might fix the problem.

Senth commented 7 years ago

I'd also be vary in general of using the showcase feature on Dialogs. You probably have a good reason. In any case you can check Google's own guidelines here and see if you can design it differently.

Material Dialog Guidelines Material Feature Discovery Guidelines

rafalzawadzki commented 7 years ago

Hey @Senth, thanks for looking into the problem and providing with all this valuable information. I will check out your suggestions and report if I come up with any solution.