[x] Relative time is calculated incorrectly. Server sends unix timestamp in seconds.
[x] Let's change the colors to match the logo. Green as #8DD97F and Red as #BC5757.
[x] Set the range to have a minimum and maximum equal to absolute maximum value in the datasets.
[x] Move all data processing outside the render function. We do not have to recompute most of the values we are computing every time we render. Handle processing in initialisation, or if the data is coming in through the network, process it after the response has been received.
[x] Change .chart--title in the homepage from an h1 to and h2.
[x] Add a description in a p tag which contains a brief introduction to what the chart is showing.
[x] Add happy face svg onto the top left corner of the all trends chart.
[x] Add sad face svg onto the bottom left corner of the all trends chart.
OR
[x] Add a legend with indicating what the graph means.
[x] Time should not repeat itself on the specific trends chart.
I will provide you with the SVGs as soon as possible, just use an img tag without a src attribute, if you wanna work on it and I have yet to upload them.
omarchehab98
commented
7 years ago
[x] Relative time is calculated incorrectly. Server sends unix timestamp in seconds.
[x] Let's change the colors to match the logo. Green as #8DD97F and Red as #BC5757.
[x] Set the range to have a minimum and maximum equal to absolute maximum value in the datasets.
[x] Move all data processing outside the render function. We do not have to recompute most of the values we are computing every time we render. Handle processing in initialisation, or if the data is coming in through the network, process it after the response has been received.
[x] Change
.chart--titlein the homepage from anh1to andh2.[x] Add a description in a
ptag which contains a brief introduction to what the chart is showing.[x] Add happy face svg onto the top left corner of the all trends chart.
[x] Add sad face svg onto the bottom left corner of the all trends chart. OR
[x] Add a legend with indicating what the graph means.
[x] Time should not repeat itself on the specific trends chart.
I will provide you with the SVGs as soon as possible, just use an
imgtag without asrcattribute, if you wanna work on it and I have yet to upload them.