search

Sentinal4D / cellshape-cloud

BSD 3-Clause "New" or "Revised" License
5 stars 3 forks source link

Fixed numpy version #13

Closed kapoorlab closed 1 year ago

kapoorlab commented 1 year ago

Describe the bug The numpy version is fixed in the setup file, maybe it could be specified to be a version greater than the fixed specified version or is there a reason to hard fix it?

To Reproduce Steps to reproduce the behavior: See the fixed version number in the setup file

Expected behavior To specify a version greater than a certain version, this can lead to unexpected behaviour like rolling a numpy version in the environment by uninstalling the installed numpy versi.

DeVriesMatt commented 1 year ago

Hi @kapoorlab, thank you for your suggestion! The reason for specifying numpy version 1.21 was that we were initially using PyMesh, and this version was required for that. We have now moved to trimesh, so I can remove this fixed version number.

DeVriesMatt commented 1 year ago

The commit 84ec1be solves the issue.