Update to 1.21 - Githubissues

SentixDev / squaremarker

Simple marker addon for squaremap.

14 stars 4 forks source link

Update to 1.21 #26

Closed Wolfdv1 closed 2 months ago

Wolfdv1 commented 2 months ago

Update to support mc 1.21
Support squaremap 1.2.5

jpenilla commented 2 months ago

Thanks for the PR and testing, there were quite a few unnecessary changes however, so I found it easier to redo the update myself in https://github.com/SentixDev/squaremarker/pull/21/commits/186c37d1a3e641c10f0e49fc76d7651e443ae538.

Wolfdv1 commented 2 months ago

Understood, glad was able to help and find the shadowjar issue with packaging causing neoforge issues- everything else was quite trivial so makes sense- apologies also am new to git and this so yeah see 100% how the commit history would be woefully unuseful haha, still learning and finding projects like this to try help on helps a bunch (working solo can reinforce bad practice)! Cheers and have a good day!