search

SentixDev / squaremarker

Simple marker addon for squaremap.
14 stars 4 forks source link

Dependancy issue with adventure-text-logger-slf4j on neoforge #28

Closed Wolfdv1 closed 2 months ago

Wolfdv1 commented 2 months ago 
       NeoForge: 21.0.21-beta[12:02:02] [main/ERROR] [minecraft/Main]: Failed to start the minecraft server
net.neoforged.fml.ModLoadingException: Loading errors encountered:
        - squaremarker (squaremarker) has failed to load correctly
          java.lang.NoClassDefFoundError: net/kyori/adventure/text/logger/slf4j/ComponentLogger

This was one of the minor fixes I adjusted in my PR to make it work with neoforge again- for reference I had to fully include this module, exclude some of adventure-text-logger-slf4js' transitive deps, and manually include org.slf4j.

Can be seen here

Likely a workaround from some deeper shadow issues with neoforge, since it lacks native or extended adventure platform support, but hey I got it working, so although I don't use forge might be useful to some :)

Wolfdv1 commented 2 months ago

Also, in testing to see if there we're any changes that caused this- looking for a cleaner fix than done in the common buildscript in my pr, I did find that this issue is longstanding: the latest release of Squaremarker, for 1.20.2 with the appropriate release of Squaremap faces the same issue:

image