search

Sentropic / SkillAPI-s

A flexible API for easily creating skills and classes with visual skill trees
13 stars 10 forks source link

Dynamic Editor: Not using 1.12 IDs #24

Closed Lovyxia closed 3 years ago

Lovyxia commented 3 years ago

Note: Aside from English, I also speak Spanish, and can understand Portuguese and French, so you can post the issue in the language you prefer among those.

Describe the bug When I wanted to apply "Mob Spell" particles, there were only newer names for them such as "Spell Mob", same goes for example for "Red Dust" (1.12) which is instead "Redstone" (newer).

This might also apply for other mechanics that involve IDs that changed since 1.13 or later.

To Reproduce Steps to reproduce the behavior:

  1. Set the Dynamic Editor to 1.12
  2. Open particle selection on a "Particle" mechanic.

Expected behavior 1.12 compatible values should be shown.

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

Lovyxia commented 3 years ago

grafik grafik

Here are screenshots for comparison between the editor for original SkillAPI (2nd picture) and SkillAPI-s (1st picture), showing the difference in particle IDs.

Lovyxia commented 3 years ago

Update: This is no longer of importance to me personally. SkillAPI-s seems to have a number of other issues with 1.12 however.

Sentropic commented 3 years ago

This is intentional, as alot of the old names were very arbitrary. I changed it so that it always uses the Bukkit values to avoid confusions using obsolete names. All the previously supported particle names are still there.