search

SeongGino / ir-light-gun-plus

Arduino powered IR light gun - with force-feedback additions, MAMEHOOKER support, quality of life changes, and (possibly) dubious code quality!
GNU Lesser General Public License v2.1
28 stars 3 forks source link

Dynamically create NeoPixel objects #23

Closed SeongGino closed 6 months ago

SeongGino commented 7 months ago

Original implem only created a static object with values that make no sense whatsoever as soon as data is loaded in setup().

PR is waiting for Pixel-using tester to confirm that this actually works, as I don't own one.

SeongGino commented 7 months ago

Apparently this version causes some havoc, so this will be left pending as a draft until I get some Pixels to physically test this with.

SeongGino commented 6 months ago

Can at least verify this version has no stability regressions on boards without NeoPixels, regardless of if it's assigned or not. Awaiting new feedback from a Pixel-using user before going ahead again.

SeongGino commented 6 months ago

Tester said all is good!