search

SeoulTech / slack-save-a-link-bot

REST API exercise — a bot that saves messges from Slack
Apache License 2.0
1 stars 0 forks source link

Haskell #5

Open heruka-urgyen opened 9 years ago

heruka-urgyen commented 9 years ago

Initial Haskell implementation. Returns JSON, doesn't use any templates for client-side. A common client-side app will be in a separate pull-request.

bzz commented 9 years ago

Why do not we have this PR on top of #3 and not a master (so may be re-create it)? Also may be it should start with 'initial haskell commit' and does not have anything metheor-related too (even if that's a deletion)

Do you have experience in interactive re-basing? It's super simple with git, but let me know if you need a hand here

heruka-urgyen commented 9 years ago

What do you think if we have this read from external source

Good idea.

Why do not we have this PR on top of #3

Sorry, my bad. I'll try to rebase it.

bzz commented 9 years ago

Why do not we have this PR on top of #3

Sorry, my bad. I'll try to rebase it.

Sometimes just re-creating a PR is enough and I think that the case here, just create new PR on top of #3 Reabse usually referees actually moving commits around and looks like 'initial haskel' is the first one here.. though now I'm not sure who's parent of 'haskel' branch in git