search

SepShr / MLCSHE

This repo houses the ML-Component Systemic Hazard Envelope project, or MILSCHE (pronounced /'mɪlʃ/).
MIT License
3 stars 0 forks source link

unclear parameters in `mutate_time()` #41

Closed donghwan-shin closed 2 years ago

donghwan-shin commented 2 years ago

Below is the current mutate_time(): https://github.com/SepShr/MLCSHE/blob/e8b3ef43f54d829cfabc7f8eae76712ca6c879f9/problem_utils.py#L185-L196

Here, I found that mutipb is coming from mutgmu as below.

https://github.com/SepShr/MLCSHE/blob/e8b3ef43f54d829cfabc7f8eae76712ca6c879f9/problem_utils.py#L171-L176

Something is wrong, isn't it?

For example, I also found that guassian_mutation_mean = 0 in search_config.py. Note that random() in the if-statement always returns a value between 0 and 1, and therefore the content of the if-statement will not be properly executed if you use guassian_mutation_mean = 0. Need to check this point.

SepShr commented 2 years ago

Thank you for discovering the mistake. Commit 00f6cdde9e47e4fa395e320833fc5b072925d438 addresses this issue.