search

Sephiroth87 / ODRefreshControl

A pull down to refresh control like the one in Apple's iOS6 Mail App
MIT License
2.15k stars 385 forks source link

section header are not scrolled to the top during refreshing #23

Closed ghost closed 12 years ago

ghost commented 12 years ago

Due to the edge insets of scrollview, which is set during refresh, tableView's section headers are not scrolled to the top of table view. I made a few change, but not sure it's a good idea. https://github.com/minorblend/ODRefreshControl/commit/d5270644a649e3c4f6f8166e8acbe2603f579510

Sephiroth87 commented 12 years ago

Thanks, I'll take a look at it soon :)

x2on commented 12 years ago

+1

Sephiroth87 commented 12 years ago

Ok, it should be fixed with https://github.com/Sephiroth87/ODRefreshControl/commit/5e336c5f0b29a8ff821d6c997ca7a7aae1756675

Can you both confirm if the issue can be closed, or i missed something? Thanks

ghost commented 12 years ago

@Sephiroth87 btw, 27a5ba9ddf9be5a82bf77290628f74572dbdf65f caused contentInsets to be set incorrectly when scroll view bounced. I think this is the issue #27. commit 5e336c5f0b29a8ff821d6c997ca7a7aae1756675 seems resolve the issue #23 quite well, at least in my case.

ghost commented 12 years ago

works like a charm =)