search

Sephiroth87 / ODRefreshControl

A pull down to refresh control like the one in Apple's iOS6 Mail App
MIT License
2.15k stars 385 forks source link

2.0 Control below section header #74

Open CyberMew opened 9 years ago

CyberMew commented 9 years ago

The control is appearing below the section header when it isn't displayed yet, so it appears to be appearing out of nowhere in the table

Sephiroth87 commented 9 years ago

Do you have a screenshot / sample code? It seems working here...

ios simulator screen shot 16 apr 2015 16 53 57 ios simulator screen shot 16 apr 2015 16 53 55

CyberMew commented 9 years ago

screen shot 2015-04-17 at 10 52 33 am numberOfSections method is returning 0

CyberMew commented 9 years ago

Upon further checking it seems like everything is correct except for the visual starting point of the blob. If it is shifted up, then it's correct.

michaelnew commented 9 years ago

I get this issue as well. It looks like it's insetting the little refresh indicator by the height of the navigation bar. If I change the navigationBarInset method in ODRefreshControl.m to always return 0 it fixes the problem. My app doesn't target iOS 7, so I can't test on that, but it may come down to a difference between how iOS7 and 8 do layout.

Sephiroth87 commented 9 years ago

@mikenew12 sorry for the late reply, but would you be able to send me a sample project with the issue? navigationBarInset is supposed to handle the iOS7+ translucent bar which changes the scrollView contentInset, and it should return 0 when that behaviour is disabled...

I haven't been able to replicate this yet, so if you have something it would really help. Thanks