Question about dealloc - Githubissues

Sephiroth87 / ODRefreshControl

A pull down to refresh control like the one in Apple's iOS6 Mail App

MIT License

2.15k stars 385 forks source link

Question about dealloc #82

Open gfxcc opened 8 years ago

gfxcc commented 8 years ago

why you implement dealloc like this?

(void)dealloc { [self.scrollView removeObserver:self forKeyPath:@"contentOffset"]; [self.scrollView removeObserver:self forKeyPath:@"contentInset"]; self.scrollView = nil; }
(void)willMoveToSuperview:(UIView *)newSuperview { [super willMoveToSuperview:newSuperview]; if (!newSuperview) { [self.scrollView removeObserver:self forKeyPath:@"contentOffset"]; [self.scrollView removeObserver:self forKeyPath:@"contentInset"]; self.scrollView = nil; } }

why not just removeObserver in (void)willMoveToSuperview like this:

(void)willMoveToSuperview:(UIView *)newSuperview { [super willMoveToSuperview:newSuperview]; [self.scrollView removeObserver:self forKeyPath:@"contentOffset"]; [self.scrollView removeObserver:self forKeyPath:@"contentInset"]; self.scrollView = nil; }

Another question, when the function dealloc will be called?

Thanks