add prop to style primary meaning and reading during reviews

[wrex]

As it stands the primary meaning is literally the lowest contrast text on your screen when you open the info panel during a review. The info you expressly ask for is the hardest to see (not optimal).

I'm going to try to tackle some of the changes today. I'll likely work on this as well.

[wrex]

I've implemented this in the branch https://github.com/Sepitus-exe/WKElementaryDark/tree/118-march23-update

Holy cats it makes a big quality of life improvement!

Before:

(It would have made more sense if I'd answered incorrectly, but try to find the primary meaning!).

After:

[Sepitus-exe]

While the solution to this issue has been included in the last PR and is now in the wild as a part of the live release, I will keep this issue open, since I wish to modify the implementation in the near future

[shdwns]

''Vocabulary Reading'' panel also should be the flat #282828 instead of the default WK gradient one

[wrex]

''Vocabulary Reading'' panel also should be the flat #282828 instead of the default WK gradient one

I'm not sure what you're referring to. Review or lesson pages? The lesson pages have several PRs awaiting approval from @Sepitus-exe.

The review page styles it the div with the text "Vocabulary Reading" using --ED-reading (#282828) correctly, as shown in the comment above.

[shdwns]

I thought it supposed to look like the one on the bottom since the current one uses the default WK style in reviews/lessons

[wrex]

Ah, I see. Yes you're right. It's currently being overriden with this more specific rule:

.quiz-input__question-type-container[data-question-type=reading] {
    background-image: linear-gradient(#3C3C3C, #1A1A1A);
    border-top: 1px solid #555;
    border-bottom: 1px solid #000;
    color: #fff;
    text-shadow: 0 1px 0 rgba(0,0,0,0.2);
}

@Sepitus-exe This is pretty easy to fix, but I'll let you handle it since I'm unsure what you were referring to here

[wrex]

'Vocabulary Reading'' panel also should be the flat #282828 instead of the default WK gradient one

The fix for this is included in PR #136

You can manually install this version until @Sepitus-exe has time to review all the changes:

https://raw.githubusercontent.com/Sepitus-exe/WKElementaryDark/march-unified/WKElementaryDark.css

[shdwns]

Uhh, i think the new update brought some new problems... This one happens in review And this one also looks somewhat weird

[wrex]

It would be helpful if you could describe what you expect to see and what you mean by "new update".

I have no idea what version of the WKED stylesheet you are running.

The default WK stylsheet (what you'll see if you disable all stylus stylsheets) has a pretty dramatic hover effect. I think that might be what you are seeing in the first image. If you move your mouse it should go back to normal size.

What exactly is weird in the second image? It appears to be rendering as intended (with --ED-radical background color for the radicals)

[shdwns]

https://raw.githubusercontent.com/Sepitus-exe/WKElementaryDark/march-unified/WKElementaryDark.css

I was talking about this one, I installed it through copying and pasting the whole code in a new stylesheet. I don't know if that is the reason for the bug So this is the default wanikani And this is the official WKED that is on userstyles.world and this is the one i installed myself

[shdwns]

The default WK stylsheet (what you'll see if you disable all stylus stylsheets) has a pretty dramatic hover effect. I think that might be what you are seeing in the first image. If you move your mouse it should go back to normal size.

this is without hovering and this is with hovering these are PR https://github.com/Sepitus-exe/WKElementaryDark/pull/136 without hover with hover and this is the one that is on userstyles.world

[wrex]

Thanks. That's helpful.

I think @Sepitus-exe has other priorities at the moment. It's not my repository, so bear with us for a few more days.

I'll use the following names:

• "Vanilla" = the default WK styling (after the recent update)

• "Published" = WKElementaryDark.css currently on userstyles.world. This is pretty broken since the update. I think it includes my first emergency patch, but none of the six outstanding PRs

• "Unified" = WKElementaryDark.css from my "march unified" branch that merges the other five PRs into one.

For some bizarre reason, the vanilla WK style applied a fixed 44px width and height to the radicals in the Radical Combination section. For reasons I'm not completely sure about, this caused the published WKED stylesheet to show the radicals in the "Radical Combinations" section to appear small and shifted off of the baseline. So I removed the fixed width and height in the unified patch.

Unfortunately, the vanilla styles also override the background color (so it's a surface color, not the background color).

The unified patch is at least legible and understandable, so I'm loathe to create another PR until @Sepitus-exe has some time to review.

I created issue #137 to track this. I've actually already written the code to make it look like the following, but I won't submit a PR for it yet:

normal:

hover:

(Requires adding an !important tag to the background color, and adding some padding to this rule:

.page-header__icon--radical, .radical-highlight, .component-character--radical .component-character__characters {
    background-color: var(--ED-radical) !important;
    background-image: none;
    padding: 0.2em;
}

Going forward, please create separate issues for anything else you find. This issue is about something else entirely.