Sepitus-exe / WKElementaryDark

A user css theme for the wanikani domain
MIT License
3 stars 1 forks source link

Burned items should be greyed out in Kanji Composition accordion #131

Open wrex opened 1 year ago

wrex commented 1 year ago

Currently only the meaning and reading are greyed:

Screenshot 2023-03-31 at 1 50 25 PM

The kanji itself should also used the --ED-text-greyed text color.

shdwns commented 1 year ago

Along with this, i think the new item mark is also supposed to be orange image

wrex commented 1 year ago

i think the new item mark is also supposed to be orange

We don't currently have a properties defined for the new/active/burned badge colors (locked has an effect applied), but probably should.

We use the "brand" color for that 新 badge currently. Unfortunately, in the default WKED colors, the "brand" color and the "kanji" color are the same. With my override colors it looks like this:

Screenshot 2023-04-01 at 9 38 15 AM

Let me think about this a bit. The "brand" color isn't really used very much, nor is it used consistently. It should probably be replaced.

I'm leaning toward getting rid of --ED-brand and replacing it with two properties:

Most sites I've built have a consistent "brand" color, but a functional site like this is a little different.

Currently, the review-forecast bars also use the --ED-brand color. I'm undecided if they should become --ED-chrome or --ED-progress.