Septima / qgis-geosearch

QGIS plugin with a search box which enables the user to quickly zoom to named places in Denmark
GNU General Public License v3.0
9 stars 7 forks source link

KF bruger og password gemmes ikke #25

Closed AsgerPetersen closed 8 years ago

AsgerPetersen commented 8 years ago

@giovanniborella rapporterede dette i #8 :

[...]gør det muligt at gemme ens login-oplysninger, så man ikke skal taste dem ind hver gang man genstarter Qgis [windows] QGIS 2.14.0(startes med grass), windows 7

AsgerPetersen commented 8 years ago

In the process of reviewing #26 I noticed another bug.

In the method show_settings_dialog https://github.com/Septima/qgis-geosearch/blob/883324e4c9d11d76f2aca99d6467f63578bec616/src/geosearch_dk/searchbox.py#L268-L295 the line self.updateconfig() https://github.com/Septima/qgis-geosearch/blob/883324e4c9d11d76f2aca99d6467f63578bec616/src/geosearch_dk/searchbox.py#L280 is responsible for saving the updated config. So it should of course be called at the end of the method.

Since this change we have effectively not saved municipality codes. And the other settings would only be saved if the user opened the settings dialog twice...