search

Septima / qgis-geosearch

QGIS plugin with a search box which enables the user to quickly zoom to named places in Denmark
GNU General Public License v3.0
9 stars 7 forks source link

Change "muncodes" setting from string-array to simple string #26

Closed bvthomsen closed 8 years ago

bvthomsen commented 8 years ago

The use of a string-array for setting "muncodes" is the cause of some trouble ( #24 ) in septima - master branch.

This pull request remedy this by changing the "muncodes" setting to a simple string.

This is not tested on a linux- or mac- based pc, but works on Windows - both with settings in registry and settings saved in a ini-file (-configpath parametr used).

Further, the patch will convert existing settings to the new format (using a butt ugly hack)

AsgerPetersen commented 8 years ago

Hi @bvthomsen

Thank you very much!

@GregersP could you try this one out in Ubuntu? I will test it in OSX for what it is worth :-)

GregersP commented 8 years ago

Does this still need testing on Ubuntu? With #24 fixed and all? If so I'll give it a spin :)

AsgerPetersen commented 8 years ago

@gregersp no. Could you please test if the fix in master for #24 also works on Ubuntu?

GregersP commented 8 years ago

It works - as commented on the issue :+1:

AsgerPetersen commented 8 years ago

I will close this pull request noting that it demonstrated the issue clearly and showed a solution which the final fix was sketched over. Thank you @bvthomsen

bvthomsen commented 8 years ago

Ok for me :-)