Closed medgoprot closed 1 year ago
I just pushed out a beta that I think may fix this - can you give it a try and let me know if it does or doesn't solve this issue? https://github.com/Sequel-Ace/Sequel-Ace/releases
@Jason-Morcos Unfortunately I still get a crash when trying to connect. Here's logs if they're any different:
@Sequel-Ace/all Is anyone able to reproduce this and identify the cause? I can't get it to crash myself, and Xcode doesn't want to symbolicate anything usefully apparently
I looked at the relevant Sequel Ace code as well as the mysqlclient library source. Nothing explictly jumped out at me. I also tried passing NULL to the connection method we're calling and only got it to crash when forcibly passing NULL for the connection, which isn't possible in normal operation AFAICT.
We use UTF8String and cStringUsingEncoding in a number of places. The docs for these methods say that the lifetime of the returned pointer is not guranteed, and that if you need to pass it around, to make a local copy. It sounds like it could be related, but the code in question hasn't been changed in forever. Was 4.0.9 built with a different version of Xcode?
@medgoprot Can you confirm what the latest version is that doesn't crash for you?
@medgoprot @azagoru @polycode-nz New beta! Can you please try 4.0.10 beta 2 and see if that resolves this issue? https://github.com/Sequel-Ace/Sequel-Ace/releases/tag/beta%2F4.0.10-20054
I looked at the relevant Sequel Ace code as well as the mysqlclient library source. Nothing explictly jumped out at me. I also tried passing NULL to the connection method we're calling and only got it to crash when forcibly passing NULL for the connection, which isn't possible in normal operation AFAICT.
We use UTF8String and cStringUsingEncoding in a number of places. The docs for these methods say that the lifetime of the returned pointer is not guranteed, and that if you need to pass it around, to make a local copy. It sounds like it could be related, but the code in question hasn't been changed in forever. Was 4.0.9 built with a different version of Xcode?
@medgoprot Can you confirm what the latest version is that doesn't crash for you?
Somehow I missed this @robinkunde - Thank you for the investigation! I tried reverting a few of the threading changes I had tried in 4.0.9 that turned out to be unnecessary for fixing the Sonoma hang. Hoping one of those might happen to be the problem. But if not, definitely stumped. 4.0.9 was the first version built with 15 for macOS Sonoma
@Jason-Morcos unfortunately no change.
Just to see when it happens I added a name in the connection panel and clicked Test connection. Results in a modal, insufficient connection details.
Entered a host of 127.0.0.1 and clicked test connection = crash.
Entering full legit details = also crash.
Darn, thank you for testing @polycode-nz. Are you able to build the app locally and see where the crash throws in Xcode? I wonder if it's related to the PR to fix backgrounding. Which would be interesting to try reverting next - https://github.com/Sequel-Ace/Sequel-Ace/pull/1849
The only bug reports so far are coming from folks running older major versions of macOS.
Maybe it's time to drop old versions of macOS (older than 11.0 for example).
I only recently updated! I'm on Big Sur 11.7.10 (20G1427) release September 11, 2023
Same here. It crashes whenever I attempt to connect to any server.
Process: Sequel Ace [22991]
Path: /Applications/Sequel Ace.app/Contents/MacOS/Sequel Ace
Identifier: com.sequel-ace.sequel-ace
Version: 4.0.9 (20052)
App Item ID: 1518036000
App External ID: 860235150
Code Type: X86-64 (Native)
Parent Process: ??? [1]
Responsible: Sequel Ace [22991]
User ID: 501
Date/Time: 2023-10-03 10:46:30.250 +0300
OS Version: Mac OS X 10.15.7 (19H1030)
Report Version: 12
Time Awake Since Boot: 10000 seconds
Time Since Wake: 1800 seconds
System Integrity Protection: enabled
Crashed Thread: 14
Exception Type: EXC_BAD_ACCESS (SIGSEGV)
Exception Codes: KERN_INVALID_ADDRESS at 0x0000000000000000
Exception Note: EXC_CORPSE_NOTIFY
Termination Signal: Segmentation fault: 11
Termination Reason: Namespace SIGNAL, Code 0xb
Terminating Process: exc handler [22991]
I can provide more stack trace if needed. Unfortunately, 4.0.10 (20054) Beta 2 didn't help. Reverted to 4.0.8 Build 20051 and it all works just fine.
Can you confirm what the latest version is that doesn't crash for you?
I reverted to version 4.0.8 (20051) which was working fine for me.
New beta! Can you please try 4.0.10 beta 2 and see if that resolves this issue?
Tried it, unfortunately same issue.
Crashing for me too. Im on 4.0.9 | I'm on Big Sur 11.7.10 Not sure if this helps but, output commandline:
2023-10-03 13:58:21.317 Sequel Ace[99855:4372244] [AppCenterCrashes] ERROR: +[MSACWrapperExceptionManager loadWrapperExceptionWithBaseFilename:]/139 Exception data report doesn't exist on disk. File name: last_saved_wrapper_exception 2023-10-03 13:58:21.327 Sequel Ace[99855:4372244] [AppCenterCrashes] ERROR: +[MSACWrapperExceptionManager loadWrapperExceptionWithBaseFilename:]/139 Exception data report doesn't exist on disk. File name: 5B3148A3-924F-4FBC-B597-67773F1DFADD zsh: segmentation fault /Applications/Sequel\ Ace.app/Contents/MacOS/Sequel\ Ace
It's crashing for me on 4.0.9, but I'm on Catalina 10.15.7 (version locked 2013 iMac). I have reverted to 4.0.8 for now.
@medgoprot @azagoru @polycode-nz New beta! Can you please try 4.0.10 beta 2 and see if that resolves this issue? https://github.com/Sequel-Ace/Sequel-Ace/releases/tag/beta%2F4.0.10-20054
Same for me, still crashing on Big Sur 11.7.9. Feel free to mention me to test any upcoming betas, I'd love this to be fixed :)
@Jason-Morcos All the crashes I'm seeing are from macOS versions 11.7 and older. I do wonder if it has something to do with building on Xcode 15. Could you create a beta of 4.0.8 using Xcode 15 and see if that crashes as well?
Worth a try! Thie one's a funky one - but still notarized for security Sequel Ace Beta-4.0.8-xcode15.zip
And one other thing to try too - this is the latest 4.0.10 built in Xcode 15 with a special linker flag set called ld64 AND with debugging enabled. That should ideally either not crash, or crash and tell us a better error message. In any case, still notarized for security Sequel Ace-debugging-ld64.zip
@Jason-Morcos both failed with a crash. The report from the ld64 version is (long, lol):
Process: Sequel Ace [76384] Path: /private/var/folders/*/Sequel Ace.app/Contents/MacOS/Sequel Ace Identifier: com.sequel-ace.sequel-ace Version: 4.0.10 (20054) Code Type: X86-64 (Native) Parent Process: ??? [1] Responsible: Sequel Ace [76384] User ID: 501
Date/Time: 2023-10-04 19:47:01.448 +1300 OS Version: macOS 11.7.10 (20G1427) Report Version: 12 Bridge OS Version: 7.6 (20P6072) Anonymous UUID: A8EEA514-7006-428B-BC90-1C0DDD3BF04E
Sleep/Wake UUID: A437C11D-1688-4F41-82DB-E4917A6C949F
Time Awake Since Boot: 70000 seconds Time Since Wake: 140 seconds
System Integrity Protection: enabled
Notes: Translocated Process
Crashed Thread: 14
Exception Type: EXC_BAD_ACCESS (SIGSEGV) Exception Codes: KERN_INVALID_ADDRESS at 0x0000000000000000 Exception Note: EXC_CORPSE_NOTIFY
Termination Signal: Segmentation fault: 11 Termination Reason: Namespace SIGNAL, Code 0xb Terminating Process: exc handler [76384]
VM Regions Near 0: --> __TEXT 10efc9000-10f409000 [ 4352K] r-x/r-x SM=COW /var/folders/*/Sequel Ace.app/Contents/MacOS/Sequel Ace
Thread 0:: Dispatch queue: com.apple.main-thread 0 libsystem_kernel.dylib 0x00007fff206d429a mach_msg_trap + 10 1 libsystem_kernel.dylib 0x00007fff206d460c mach_msg + 60 2 com.apple.CoreFoundation 0x00007fff20801ebf CFRunLoopServiceMachPort + 316 3 com.apple.CoreFoundation 0x00007fff2080059f CFRunLoopRun + 1328 4 com.apple.CoreFoundation 0x00007fff207ff9ac CFRunLoopRunSpecific + 563 5 com.apple.HIToolbox 0x00007fff28a4a1f3 RunCurrentEventLoopInMode + 292 6 com.apple.HIToolbox 0x00007fff28a49f55 ReceiveNextEventCommon + 587 7 com.apple.HIToolbox 0x00007fff28a49cf3 _BlockUntilNextEventMatchingListInModeWithFilter + 70 8 com.apple.AppKit 0x00007fff23009ad2 _DPSNextEvent + 864 9 com.apple.AppKit 0x00007fff230082a5 -[NSApplication(NSEvent) _nextEventMatchingEventMask:untilDate:inMode:dequeue:] + 1364 10 com.apple.AppKit 0x00007fff22ffa5c9 -[NSApplication run] + 586 11 com.apple.AppKit 0x00007fff22fce7cc NSApplicationMain + 816 12 libdyld.dylib 0x00007fff20724f3d start + 1
Thread 1: 0 libsystem_pthread.dylib 0x00007fff20705420 start_wqthread + 0
Thread 2: 0 libsystem_pthread.dylib 0x00007fff20705420 start_wqthread + 0
Thread 3: 0 libsystem_pthread.dylib 0x00007fff20705420 start_wqthread + 0
Thread 4: 0 libsystem_pthread.dylib 0x00007fff20705420 start_wqthread + 0
Thread 5: 0 libsystem_pthread.dylib 0x00007fff20705420 start_wqthread + 0
Thread 6: 0 libsystem_pthread.dylib 0x00007fff20705420 start_wqthread + 0
Thread 7: 0 libsystem_kernel.dylib 0x00007fff206d429a mach_msg_trap + 10 1 libsystem_kernel.dylib 0x00007fff206d460c mach_msg + 60 2 com.sequel-ace.sequel-ace 0x000000010f341fd5 0x10efc9000 + 3641301 3 libsystem_pthread.dylib 0x00007fff207098fc _pthread_start + 224 4 libsystem_pthread.dylib 0x00007fff20705443 thread_start + 15
Thread 8:: JavaScriptCore bmalloc scavenger
0 libsystem_kernel.dylib 0x00007fff206d6cbe psynch_cvwait + 10
1 libsystem_pthread.dylib 0x00007fff20709e49 _pthread_cond_wait + 1298
2 libc++.1.dylib 0x00007fff20672d72 std::__1::condition_variable::wait(std::1::unique_lock
Thread 9: 0 libsystem_pthread.dylib 0x00007fff20705420 start_wqthread + 0
Thread 10: 0 libsystem_pthread.dylib 0x00007fff20705420 start_wqthread + 0
Thread 11:: com.apple.NSEventThread 0 libsystem_kernel.dylib 0x00007fff206d429a mach_msg_trap + 10 1 libsystem_kernel.dylib 0x00007fff206d460c mach_msg + 60 2 com.apple.CoreFoundation 0x00007fff20801ebf CFRunLoopServiceMachPort + 316 3 com.apple.CoreFoundation 0x00007fff2080059f CFRunLoopRun + 1328 4 com.apple.CoreFoundation 0x00007fff207ff9ac CFRunLoopRunSpecific + 563 5 com.apple.AppKit 0x00007fff2318fb7a _NSEventThread + 124 6 libsystem_pthread.dylib 0x00007fff207098fc _pthread_start + 224 7 libsystem_pthread.dylib 0x00007fff20705443 thread_start + 15
Thread 12:: com.apple.NSURLConnectionLoader 0 libsystem_kernel.dylib 0x00007fff206d429a mach_msg_trap + 10 1 libsystem_kernel.dylib 0x00007fff206d460c mach_msg + 60 2 com.apple.CoreFoundation 0x00007fff20801ebf CFRunLoopServiceMachPort + 316 3 com.apple.CoreFoundation 0x00007fff2080059f CFRunLoopRun + 1328 4 com.apple.CoreFoundation 0x00007fff207ff9ac CFRunLoopRunSpecific + 563 5 com.apple.CFNetwork 0x00007fff24ca9290 0x7fff24a6a000 + 2355856 6 com.apple.Foundation 0x00007fff2158b487 NSThreadstart__ + 1068 7 libsystem_pthread.dylib 0x00007fff207098fc _pthread_start + 224 8 libsystem_pthread.dylib 0x00007fff20705443 thread_start + 15
Thread 13: 0 libsystem_pthread.dylib 0x00007fff20705420 start_wqthread + 0
Thread 14 Crashed: 0 ??? 000000000000000000 0 + 0 1 com.sequel-ace.spmysql 0x000000010f5ae9e9 mysql_options4 + 329 2 com.sequel-ace.spmysql 0x000000010f5ac15c csm_begin_connect(mysql_async_connect*) + 348 3 com.sequel-ace.spmysql 0x000000010f5abf85 mysql_real_connect + 197 4 com.sequel-ace.spmysql 0x000000010f58fe2f -[SPMySQLConnection(PrivateAPI) _makeRawMySQLConnectionWithEncoding:isMasterConnection:] + 1429 5 com.sequel-ace.spmysql 0x000000010f58f615 -[SPMySQLConnection(PrivateAPI) _connect] + 310 6 com.sequel-ace.sequel-ace 0x000000010f0db0f5 0x10efc9000 + 1122549 7 com.sequel-ace.sequel-ace 0x000000010f19aabe 0x10efc9000 + 1907390 8 com.apple.Foundation 0x00007fff2158b487 NSThreadstart__ + 1068 9 libsystem_pthread.dylib 0x00007fff207098fc _pthread_start + 224 10 libsystem_pthread.dylib 0x00007fff20705443 thread_start + 15
Thread 14 crashed with X86 Thread State (64-bit): rax: 0x0000000000000016 rbx: 0x00006000039b58c0 rcx: 0x0000000000000001 rdx: 0x000000010f97bcec rdi: 0x0000000000000038 rsi: 0x00007fff206b6860 rbp: 0x00007000083f57e0 rsp: 0x00007000083f5738 r8: 0x0000600000bac7a8 r9: 0x0000000000000d22 r10: 0x000000010f9902a2 r11: 0x000000010f58f35d r12: 0x0000000000000000 r13: 0x00007000083f5799 r14: 0x0000000000000016 r15: 0x00007faff000a000 rip: 0x0000000000000000 rfl: 0x0000000000010246 cr2: 0x0000000000000000
Logical CPU: 0 Error Code: 0x00000014 (no mapping for user instruction read) Trap Number: 14
Thread 14 instruction stream not available.
Thread 14 last branch register state not available.
Binary Images:
0x10efc9000 - 0x10f408fff +com.sequel-ace.sequel-ace (4.0.10 - 20054) <89987CFB-14A5-32C0-BE03-35C1C2994ED0> /var/folders//Sequel Ace.app/Contents/MacOS/Sequel Ace
0x10f550000 - 0x10f55ffff +com.sequel-ace.net.wafflesoftware.ShortcutRecorder.framework.Leopard (1.0)
External Modification Summary: Calls made by other processes targeting this process: task_for_pid: 0 thread_create: 0 thread_set_state: 0 Calls made by this process: task_for_pid: 0 thread_create: 0 thread_set_state: 0 Calls made by all processes on this machine: task_for_pid: 0 thread_create: 0 thread_set_state: 0
VM Region Summary: ReadOnly portion of Libraries: Total=901.1M resident=0K(0%) swapped_out_or_unallocated=901.1M(100%) Writable regions: Total=1.7G written=0K(0%) resident=0K(0%) swapped_out=0K(0%) unallocated=1.7G(100%)
VIRTUAL REGION
REGION TYPE SIZE COUNT (non-coalesced) =========== ======= ======= Accelerate framework 512K 4 Activity Tracing 256K 1 CG backing stores 4032K 6 CG image 1168K 41 CG raster data 84K 10 CoreAnimation 43.7M 142 CoreGraphics 12K 2 CoreUI image data 5228K 45 Foundation 16K 1 Image IO 20K 5 JS VM Isolated Heap 24K 2 Kernel Alloc Once 8K 1 MALLOC 330.7M 75 MALLOC guard page 96K 17 MALLOC_MEDIUM (reserved) 960.0M 8 reserved VM address space (unallocated) MALLOC_NANO (reserved) 384.0M 1 reserved VM address space (unallocated) SQLite page cache 192K 3 STACK GUARD 56.1M 15 Stack 15.1M 15 VM_ALLOCATE 304K 25 WebKit Malloc 8296K 10 DATA 23.1M 452 DATA_CONST 25.0M 277 DATA_DIRTY 1403K 182 __FONT_DATA 4K 1 LINKEDIT 505.3M 18 OBJC_RO 70.3M 1 __OBJC_RW 2496K 3 TEXT 395.8M 449 __UNICODE 588K 1 libnetwork 128K 8 mapped file 274.7M 75 shared memory 760K 16 =========== ======= ======= TOTAL 3.0G 1912 TOTAL, minus reserved VM space 1.7G 1912
Model: MacBookPro16,1, BootROM 1968.140.7.0.0 (iBridge: 20.16.6072.0.0,0), 8 processors, 8-Core Intel Core i9, 2.3 GHz, 32 GB, SMC Graphics: kHW_IntelUHDGraphics630Item, Intel UHD Graphics 630, spdisplays_builtin Graphics: kHW_AMDRadeonPro5500MItem, AMD Radeon Pro 5500M, spdisplays_pcie_device, 4 GB Memory Module: BANK 0/ChannelA-DIMM0, 16 GB, DDR4, 2667 MHz, SK Hynix, - Memory Module: BANK 2/ChannelB-DIMM0, 16 GB, DDR4, 2667 MHz, SK Hynix, - AirPort: spairport_wireless_card_type_airport_extreme (0x14E4, 0x7BF), wl0: Aug 10 2021 20:10:47 version 9.30.444.18.32.5.71 FWID 01-30b2601e Bluetooth: Version 8.0.5d7, 3 services, 27 devices, 1 incoming serial ports Network Service: Wi-Fi, AirPort, en0 USB Device: USB 3.1 Bus USB Device: Apple T2 Bus USB Device: Composite Device USB Device: Touch Bar Backlight USB Device: Touch Bar Display USB Device: Apple Internal Keyboard / Trackpad USB Device: Headset USB Device: Ambient Light Sensor USB Device: FaceTime HD Camera (Built-in) USB Device: Apple T2 Controller Thunderbolt Bus: MacBook Pro, Apple Inc., 63.5 Thunderbolt Bus: MacBook Pro, Apple Inc., 63.5
And one other thing to try too - this is the latest 4.0.10 built in Xcode 15 with a special linker flag set called ld64 AND with debugging enabled. That should ideally either not crash, or crash and tell us a better error message. In any case, still notarized for security Sequel Ace-debugging-ld64.zip
Tried both, but none of them work unfortunately.
It looks like this is a bug in Xcode 15 🤦 https://developer.apple.com/forums/thread/731089
I had tried adding that extra linker flag, but that appears to not be enough in our case
Thank you for all the attempts! One last beta to try - https://github.com/Sequel-Ace/Sequel-Ace/releases/tag/beta%2F4.0.10-20055 ld64 tag in a different place (project as opposed to artifact) Please let me know if this somehow works 🤞
If this doesn't work, I'll cloud build this next release with Xcode 14 (Xcode 14 doesn't run on Sonoma) which theoretically should solve this for y'all in 4.0.10. But then realistically I'm gonna be forced to drop support for macOS < 12 (although the last supported version should continue to work for all of you) because it won't be long until Apple starts requiring XCode 15 for everything :/ .
^ still crashes sorry
If this doesn't work, I'll cloud build this next release with Xcode 14 (Xcode 14 doesn't run on Sonoma) which theoretically should solve this for y'all in 4.0.10. But then realistically I'm gonna be forced to drop support for macOS < 12 (although the last supported version should continue to work for all of you) because it won't be long until Apple starts requiring XCode 15 for everything :/ .
For AppStore - we should just do it via Xcode Cloud that still has Xcode 14 and will have it for some time. For other builds we could try to do it via Xcode Cloud too and just download the archive and do nothing manually - to not need to drop these versions.
Just FYI, almost same specs as OP (Big Sur 11.7.10 in my case) the Beta 3 crashes, but I can confirm 4.0.8 works fine.
When launching 4.0.8 it offers to update.
Thanks for your effort, guys :)
Please try this 4.0.10 release candidate built with Xcode 14. This should fix it
https://github.com/Sequel-Ace/Sequel-Ace/releases/tag/production%2F4.0.10-20056
Please try this 4.0.10 release candidate built with Xcode 14. This should fix it
https://github.com/Sequel-Ace/Sequel-Ace/releases/tag/production%2F4.0.10-20056
Yes! Working fine on my end.
macOS Version: Big Sur 11.7.10 Processor Type (Intel/Apple): Intel i7 MySQL Version: 8.1.0 (& others) macOS Localization: en_US
Thanks!
Awesome, thanks for fixing.
Please try this 4.0.10 release candidate built with Xcode 14. This should fix it
https://github.com/Sequel-Ace/Sequel-Ace/releases/tag/production%2F4.0.10-20056
Works here as well! macOS Catalina 10.15.7
Thank you all! So sorry for all the issues. I can tell you I'm very disappointed in this XCode release. Glad we found a way forward at least for now
Thanks @Jason-Morcos for fixing and for reminding me how bad MySQL workbench is. Absolute shambles!
Hey folks! Could you please try this latest beta and let me know if it's still working in older versions of macOS? https://github.com/Sequel-Ace/Sequel-Ace/releases/tag/beta%2F4.0.14-20063 We received some reports that the latest Xcode fixes the issues we were seeing before and I'd like to try to get us building with the latest version again if possible. Would appreciate just a few 👍 before this release goes out :) Thank you!
@Jason-Morcos I had to recreate the favorite because the beta version has a separate sandbox and set of preferences, but that beta seems to be working correctly here on 10.15.7, for both quick connect and favorites. Thanks.
Woot woot! Thank you for confirming!
Just got the 4.0.14 release, and it seems to still be working correctly on 10.15.7 so far.
Is Issue Present in Latest Beta? Yes
Description After the last update whenever I try to connect with any remote or local database the app crashes.
Steps To Reproduce
Expected Behaviour App opens normally.
Related Issues
Additional Context
crash_logs.txt