Serabe / RMagick4J

RMagick for JRuby.
Other
29 stars 13 forks source link

Draw#rotation doesn't affect annotate method #2

Closed Serabe closed 11 years ago

Serabe commented 14 years ago

Reported by Grzegorz Siehie?: I've investigated the bug a little bit more, and I found that the problem is with the rotation method in Magick::Draw object.

example source:

require 'rubygems' require 'RMagick'

canvas = Magick::ImageList.new canvas.new_image(300, 300) text = Magick::Draw.new text.font_family = 'helvetica' text.rotation = -90 text.pointsize = 52 text.gravity = Magick::CenterGravity text.annotate(canvas, 0,0,-1.5,-1.5, RUBY_PLATFORM) canvas.write("#{RUBY_PLATFORM}.png")

images generated: Attached i486-linux.png Attached java.png

executing the script (which is based on RMagick example form projects page) gives some warnings:

dfenzvps:~# jruby t.rb /usr/local/jruby/lib/ruby/gems/1.8/gems/rmagick4j-0.3.7/lib/rmagick4j/draw.rb:6 warning: &' interpreted as argument prefix /usr/local/jruby/lib/ruby/gems/1.8/gems/rmagick4j-0.3.7/lib/rmagick4j/image.rb:323 warning:&' interpreted as argument prefix

donv commented 11 years ago

Hi!

Any progress on this?

Serabe commented 11 years ago

I am not having too much time to continue with this. It seemed that nobody was using it anymore. I'm looking for making some space in my schedule to solve some bugs and making a new release, but it seems difficult for the next couple of months

donv commented 11 years ago

I'd be happy to help. A new release would be good, and as soon as this bug is fixed.

Can you give me any pointers as to where to begin looking for the cause? Do yo know if it ever worked?

donv commented 11 years ago

Hi @Serabe !

Would it be an acceptable solution to store just the last rotation separately and use that in the annotation?

donv commented 11 years ago

Hi @Serabe !

I have a very simple fix for the rotation problem. Would it be possible to get it in quickly and start on a new release?

I am releasing Gruff 0.3.8 on monday, and it would be great to have a new version of RMagick4J out as well.

I can do all the heavy lifting of getting the release out if you dare trust me :)

Serabe commented 11 years ago

I have some problems with my Rubygems' account since it was migrated from RubyForge. I have asked @enebo and @headius for access with my new account.

However, this monday is too soon for me. Let me talk with my partners so I can take a few days off next week to update RMagick4J and release a new version. Would this be ok for you?

donv commented 11 years ago

Yes, absolutely! Thank you!

Serabe commented 11 years ago

Sadly, the week is quite complicated right now. Though, I can give you access to the project if you want to.

donv commented 11 years ago

That would be great! I can prepare for the release, but to actually release, I need to made an owner on rubygems.org as well. Can you do that? ...or maybe @headius or @enebo ?

Serabe commented 11 years ago

I can do that as soon as I get home. On 7 Aug 2013 20:51, "Uwe Kubosch" notifications@github.com wrote:

That would be great! I can prepare for the release, but to actually release, I need to made an owner on rubygems.org as well. Can you do that? ...or maybe @headius https://github.com/headius or @enebohttps://github.com/enebo?

— Reply to this email directly or view it on GitHubhttps://github.com/Serabe/RMagick4J/issues/2#issuecomment-22274455 .