SerafinTech / node-red-contrib-cip-st-ethernet-ip

A Node-RED node to interact with Allen Bradley / Rockwell PLCs. SerafinTech Version
GNU General Public License v3.0
2 stars 4 forks source link

Add error output to Eth-Ip In node in order to catch unknown tags. #9

Closed GeekMeUpScotty closed 8 months ago

GeekMeUpScotty commented 9 months ago

Is your feature request related to a problem? Please describe. Since https://github.com/SerafinTech/ST-node-ethernet-ip/pull/58 was merged, the underlying library (st-ethernet-ip) will emit "Unknown" when tags not known by PLC are queried.

I am submitting a pull request to pick these events up in Node-RED.

Describe the solution you'd like The solution I am proposing and submitting a PR for is to add an option (checkbox) in config ui to attach an error output to the eth-ip in node. For now only unknown events are being send but this could be extended to all (most) errors. If the option (to add error output) is not selected, behavior is unchanged from previous releases.

Describe alternatives you've considered Non considered.

Additional context The overall idea about this is to simply pass on any errors to an external system so that configuration issues on PLC's can be monitored centrally

GeekMeUpScotty commented 8 months ago

Thanks for merging.