search

SeraphJACK / SimpleLogin

Auth mod based on forge for Minecraft 1.12+
https://www.curseforge.com/minecraft/mc-mods/simple-login
MIT License
49 stars 23 forks source link

Increased login timeout tenfold #19

Closed x13x54 closed 3 years ago

x13x54 commented 3 years ago

Fixes issue detailed in my comment at https://github.com/TheRandomLabs/RandomPatches/issues/141#issuecomment-844342890

Large modpacks can come hand-in-hand with client-side freezes lasting over a minute, causing a disconnect even if the login credentials match. Large modpacks feature mods like RandomPatches to increase the timeouts used by minecraft and forge for this reason, and despite having this mod it seemed like https://github.com/TheRandomLabs/RandomPatches/issues/141 was happening on our server as well, until i found this timeout value that exactly matches how long it takes for a player to time out on our server. Increasing this value tenfold in <server>/<world>/serverconfig/simplelogin-server.toml fixed this issue for the server i am one of the operators of. Since players should not be able to do any damage while not logged in this should not have any negative effects.

SeraphJACK commented 3 years ago

Can you try the latest version for 1.16 (1.0.0)? This version uses a different trigger to send login packets so I doubt if this issue still exists.

Also, in the latest version you can disable SimpleLogin's timeout by simply disable 'simplelogin:timeout' plugin in the server config.

x13x54 commented 3 years ago

We can try using the latest version in the near future. The server in question is currently being used by several people and the client setup instructions are complicated enough as is, so this would have to be a one-time try out. Aside from that the newest version still has the same arbitrary timeout value by default, and this might cause the same issue for other server operators who are not aware of the timeout at all (i didn't know until yesterday and found the config file by accident). I believe that increasing the timeout to a value that is not likely to be reached with just a hefty modpack can prevent others from having this same issue. From what i understand the purpose of the timeout is just to prevent unauthenticated client from idling forever, so there's no negative effect caused by letting them idle for a few more minutes. Now if someone would want to reduce that timeout for their server they would at least know where to look.

SeraphJACK commented 3 years ago

Can you also update the documentation in README.md?

x13x54 commented 3 years ago

Thanks. Will you increment the version number and add a new release to curseforge and such? It's not technically required as the function of the mod appears the same to clients and the change is serverside only. Maybe MC1.16-1.0.0-patch-1? In any case, thanks for this useful mod.

SeraphJACK commented 3 years ago

There are also some updates on password change, I'll release a new version with this pr together.