search

Seravo / gnitpick

Automated git commit message nitpicking
GNU Lesser General Public License v3.0
12 stars 2 forks source link

--target-branch argument not handled correctly causing an error #24

Closed sjaks closed 3 years ago

sjaks commented 3 years ago 
sami@pad:~/.../seravo-plugin (master) $ gnitpick --target-branch dev-sami
Traceback (most recent call last):
  File "/usr/bin/gnitpick", line 321, in <module>
    git_rev = f'{target_repository}/{target_branch}..HEAD'
NameError: name 'target_branch' is not defined

If user defines a target_branch with --target_branch, gnitpick will not execute correctly since the correct value cannot be accessed properly. If no target branch is given, gnitpick defaults to master and the program runs correctly.

Using the value of target_branch attribute is since impossible, for instance in https://github.com/Seravo/gnitpick/issues/20.