Seravo / seravo-plugin

Enhances WordPress with Seravo specific features and integrations
https://seravo.com/
GNU General Public License v2.0
38 stars 16 forks source link

wp-check-haveibeenpwned return code 1 in Vagrant #625

Closed JoosuaKoskinen closed 3 years ago

JoosuaKoskinen commented 3 years ago

Describe the bug Not exactly Seravo Plugin issue but I think we should remove the wp-check-haveibeenpwned return code check from passwords.php as it's useless and currently causing issues.

In production env:

PRODUCTION [@joosuakoskinen:~] $ wp-check-haveibeenpwned --json b03fe988f8d55b87dbd2223ee1a8a37a0f882d6e 2>&1
{"found": true}
PRODUCTION [@joosuakoskinen:~] $ $?
-bash: 0: command not found

Randomly in development env:

DEVELOPMENT [@wordpress:~/wp-content/mu-plugins/seravo-plugin] seravo-plugin-2/master(+1/-0)* 127 ± wp-check-haveibeenpwned --json b03fe988f8d55b87dbd2223ee1a8a37a0f882d6e 2>&1
{"found": true}
DEVELOPMENT [@wordpress:~/wp-content/mu-plugins/seravo-plugin] seravo-plugin-2/master(+1/-0)* 1 ± $?
-bash: 1: command not found
JoosuaKoskinen commented 3 years ago

Fixed in #629