search

Seravo / wordpress

The WordPress project layout used by many of Seravo's customers, suitable also for local development with Vagrant and git deployment
https://seravo.com
GNU General Public License v3.0
102 stars 54 forks source link

Rephrase config.yml 'avahi: true' option #116

Open l3ku opened 4 years ago

l3ku commented 4 years ago

The actual meaning of the option is currently to expose the Vagrant box on OS X to the local network via bridge interface: https://github.com/Seravo/wordpress/blob/54b867da64991451487fee23fbef0f41d6ffbd19/Vagrantfile#L89-L99 As we currently already always use Avahi in the box by default, we should maybe rephrase this option to be more logical, like public: true, bridge: true or something else. We could also consider either dropping this feature or also enable the feature for Linux depending on the actual value this feature currently provides for our customers.

ottok commented 3 years ago

The question is, what would be a better name then? If it is changed, it needs to be coordinated so that the Vagrantfile, config-example.yml in the project template and also scripts inside the Vagrant box all update at the same time, and there needs to be enough documentation in place so those who use the current setting name knows to update their config.yml files.