search

SeregPie / VueWordCloud

Generates a cloud out of the words.
https://seregpie.github.io/VueWordCloud/
MIT License
386 stars 60 forks source link

Upgrading to vue3 #56

Closed lovery closed 1 year ago

lovery commented 1 year ago

Upgrading all dependencies to the latest version

jackmcguire1 commented 1 year ago

@lovery maybe a good idea to update the README with example of mounting the component

lovery commented 1 year ago

@lovery maybe a good idea to update the README with example of mounting the component

@jackmcguire1 I didn't change the way it is mounted, I kept everything the same. May be only it is good to mention that after version 19 it required vue3, and not any more vue2.

By the way I am not sure but may be a better way is to create a new plugin with new name so it is really distinct that it needs vue3.

rahulkumarsingh73690 commented 1 year ago

Looks good please merge

rahulkumarsingh73690 commented 1 year ago

Please review this pr @SeregPie

rahulkumarsingh73690 commented 1 year ago

Any update?

SeregPie commented 1 year ago

Thank you for the contribution. I will merge it into the dev:branch and check if it is really working.