Closed Serendipity2-0 closed 1 month ago
[!CAUTION]
Review failed
The pull request is closed.
The pull request introduces several modifications across various modules, primarily focusing on enhancing transaction management and strategy retrieval. Key changes include the addition of new functions for handling debt-related transactions, updates to existing methods for improved error handling, and the introduction of a new category "Debt" in strategy fetching. Additionally, new SQLAlchemy models and utility functions are added to support these features, alongside enhancements to existing functionalities for better data management.
File Path | Change Summary |
---|---|
Executor/ExecutorUtils/BrokerCenter/BrokerCenterUtils.py | Modified fetch_active_strategies_all_users to include "Debt" category; minor formatting adjustments. |
Executor/ExecutorUtils/ExeDBUtils/ExeFirebaseAdapter/exefirebase_utils.py | Added functions for retrieving trader numbers and principal amounts. |
Executor/ExecutorUtils/ExeUtils.py | Added DEBT_STRATEGY_LIST variable for debt strategies. |
Executor/ExecutorUtils/InstrumentCenter/InstrumentCenterUtils.py | Updated method signatures for trading symbol retrieval and error handling. |
Executor/NSEStrategies/Equity/EquityStopLoss/EquityStopLoss.py | Enhanced error handling in main and process_holdings functions. |
Executor/NSEStrategies/NSEStrategiesUtil.py | Simplified update_qty_user_firebase function for equity free cash calculation. |
User/UserApi/app.py | Added functions for transaction management, including import and update capabilities. |
User/UserApi/database.py | Added functions for user-specific SQLite database management. |
User/UserApi/main.py | Introduced new router app_debt for debt-related transactions with enhanced error handling. |
User/UserApi/models.py | Added SQLAlchemy ORM models for handling transactions and accounts. |
User/UserApi/qt_debt_model.py | Introduced FastAPI application for debt management with endpoints for financial records. |
User/UserApi/schemas.py | Added new classes for database interaction. |
User/UserApi/userapi_utils.py | Added multiple utility functions for data handling and transaction management. |
BrokerCenterUtils.py
related to order handling, potentially relevant to the new "Debt" category.EodReportUtils.py
for handling trades, aligning with the focus on strategy management, including "Debt."InstrumentCenterUtils.py
for retrieving quotes based on segments, complementing the updates in the main PR.cancel_normal_orders
in BrokerCenterUtils.py
enhancing order management, relevant to the updates on fetching strategies.🐇 In the meadow where we play,
New features hop in bright array.
With debts and trades, we dance and sing,
Enhancing all the joys we bring.
So let us cheer for changes bold,
In the world of finance, watch it unfold! 🌼
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Summary by CodeRabbit
New Features
Bug Fixes
Chores